Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crashlytics, ios): add native helper log / setCustomValue methods #8104

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

user request, useful for "brownfield" apps that have custom native code and want to use crashlytics native methods from their own native code

Related issues

Fixes:

Release Summary

one conventional commit, rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

native helper methods don't have tests, compiling correctly (which it does) should be adequate as it simply copies the previous method that has reports of user success, and does nothing but copy the SDK method signature then delegate to the SDK


Think react-native-firebase is great? Please consider supporting the project with any of the below:

user request, useful for "brownfield" apps that have custom native code and want
to use crashlytics native methods from their own native code
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:17pm

@mikehardy mikehardy merged commit da1ac6b into main Oct 31, 2024
18 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/crashlytics-ios-parity branch October 31, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [firebase_crashlytics] Add methods to NativeHelper
2 participants