fix: Refix firebase ios sdk dependencies / adopt firebase-ios-sdk 11.5.0 #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firebase-ios-sdk minimum versions are much higher than this currently, these are no longer necessary
this was intended to be a static framework toggle, use correct name (vs copy-paste analytics var name) and disable it as !use_frameworks dominates the setting in practice
mikehardy
added
platform: ios
Workflow: Needs Review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Well that's unexpected: It triggered my new "could not find 11.5.0 firebase-ios-sdk" in CI Why? Possibly some missing step in workflow, unsure but queued for investigation edit: Unable to resolve even with very close inspection 🤷 - removed that check, we'll just continue to rely on built-in pod error messages, they're not too bad at least |
mikehardy
force-pushed
the
refix-firebase-ios-sdk-dependencies
branch
from
cb53aa2 to
3aef586
Compare
mikehardy
force-pushed
the
refix-firebase-ios-sdk-dependencies
branch
from
fc892a8 to
049c073
Compare
This reverts commit d03ab42. the cure was worse than the disease, see: #8127 If we constrain deps to <=, old deps may be used which is invalid If we constrain deps to =, then binary firestore-ios-sdk-frameworks does not resolve If we constrain deps to ~> like FlutterFire it may work However, we constrained this way for a long time without issue until one build break that prompted this commit, and the ~> suffered the build break as well in FlutterFire The break was fixed quickly and had a workaround, so revert appears to be the lesser of all evils
mikehardy
force-pushed
the
refix-firebase-ios-sdk-dependencies
branch
from
68758ff to
1edfe47
Compare
russellwheatley
approved these changes
Nov 13, 2024
mikehardy
removed
Workflow: Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note to reviewer: review commit by commit, the diffs are all tiny with hopefully useful messages
With #8127 I discovered that my fix for the temporary build error with firebase-ios-sdk 11.4.1 (in #8074) had a negative side effect - it constrained versions to not slip upwards but it allowed old versions to stay in place.
That is not okay, as we depend on updated versions to bring us new APIs that we use (which was the problem in #8127)
So, with this commit I'm reverting that change as the cure was worse than the disease and there is no other good way to specify the versions since
=breaks integration with firestore-ios-sdk-frameworks (I tested it, I was surprised and disappointed)I take the opportunity in separate commits to:
Related issues
Release Summary
All conventional commits so a rebase merge should work, followed by a release
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Lots of local testing of
pod installwith various settings of the firebase-ios-sdk version to see how the new fail-fast error logic behaves, and how the versions in Podfile.lock are resolvedThink
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter