Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crashlytics): refactor deprecation implementation #8155

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 22, 2024

Description

  • Use a proxy on each module instance, allows us to have all deprecation warnings in one place and to keep a map of deprecated methods and the corresponding modular method if available.
  • For testing, I have mocked the underlying FirebaseModule and proxied every get request on native object which should hopefully speed up writing tests. I had a battle on firestore unit tests mocking the query instance, and this should make it a lot easier.
  • Also updated tests to check the actual message is correct and properly cleared the jest spy as it was being polluted by firebase app() invocation.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:23pm

@russellwheatley russellwheatley changed the title test: refactor deprecation implementation chore(crashlytics): refactor deprecation implementation Nov 22, 2024
@russellwheatley russellwheatley merged commit f5d2152 into crashlytics-deprecations Nov 22, 2024
19 checks passed
@russellwheatley russellwheatley deleted the crashlytics-changes branch November 22, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant