Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firestore): deprecation warnings for v8 API ahead of future major release #8169

Merged
merged 30 commits into from
Dec 20, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 29, 2024

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:12am

@russellwheatley russellwheatley marked this pull request as ready for review December 17, 2024 16:43
@russellwheatley russellwheatley changed the title chore(firestore): deprecation warning for v8 API ahead of future major release chore(firestore): deprecation warnings for v8 API ahead of future major release Dec 17, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monster PR, amazing.
I don't see anything wrong with it other than the two now-obsolete comments.

I recognize it is semi-complicated with the proxy/reflexive stuff but I also can't think of any other way to centralize all of it without doing something similar, so still +1 on the style

Hopefully the rest of the modules are easier !

packages/app/lib/FirebaseApp.js Outdated Show resolved Hide resolved
packages/app/lib/FirebaseApp.js Outdated Show resolved Hide resolved
packages/app/lib/common/index.js Show resolved Hide resolved
@russellwheatley russellwheatley merged commit 86a128d into v8-deprecations Dec 20, 2024
19 checks passed
@russellwheatley russellwheatley deleted the firestore-deprecations branch December 20, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants