ci: add dataconnect to emulators options

invertase · Dec 22, 2024 · 5474115 · 5474115
1 parent 17a5876
commit 5474115
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -35,10 +35,12 @@ jobs:
 
       - name: Start Firebase Emulator Suite
         uses: invertase/[email protected]
+        with:
+          emulators: 'auth,firestore,functions,storage,database,dataconnect'
 
-      # Start DataConnect Emulator
-      - name: Start DataConnect Emulator
-        run: firebase emulators:start --only dataconnect --project test &
+      # # Start DataConnect Emulator
+      # - name: Start DataConnect Emulator
+      #   run: firebase emulators:start --only dataconnect --project test &
 
       - name: Verify Running Emulators
         run: |

diff --git a/dataconnect-sdk/js/default-connector/package.json b/dataconnect-sdk/js/default-connector/package.json
@@ -20,6 +20,6 @@
     "./package.json": "./package.json"
   },
   "peerDependencies": {
-    "firebase": "^10.14.0"
+    "firebase": "^10.14.0 || ^11.0.0"
   }
 }