Skip to content

Fix the application terminates if you cancel the confirmation dialog box for exit #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the application terminates if you cancel the confirmation dialog box for exit #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions invesalius/gui/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,12 +514,12 @@ def ExitDialog(self):
msg = _("Are you sure you want to exit?")
if sys.platform == "darwin":
dialog = wx.RichMessageDialog(
None, "", msg, wx.ICON_QUESTION | wx.YES_NO | wx.NO_DEFAULT
None, "", msg, wx.ICON_QUESTION | wx.OK | wx.CANCEL | wx.CANCEL_DEFAULT
)
dialog.ShowCheckBox("Store session", True)
else:
dialog = wx.RichMessageDialog(
None, msg, "Invesalius 3", wx.ICON_QUESTION | wx.YES_NO | wx.NO_DEFAULT
None, msg, "Invesalius 3", wx.ICON_QUESTION | wx.OK | wx.CANCEL | wx.CANCEL_DEFAULT
)
dialog.ShowCheckBox("Store session", True)

Expand All @@ -529,10 +529,10 @@ def ExitDialog(self):

# logger = log.MyLogger()

if not save and answer == wx.ID_YES:
if not save and answer == wx.ID_OK:
log.invLogger.closeLogging()
return 1 # Exit and delete session
elif save and answer == wx.ID_YES:
elif save and answer == wx.ID_OK:
log.invLogger.closeLogging()
return 2 # Exit without deleting session
else:
Expand Down