Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI to Go 1.17 #13

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Conversation

sergei-ivanov
Copy link
Contributor

Signed-off-by: Sergei Ivanov [email protected]

Signed-off-by: Sergei Ivanov <[email protected]>
@sergei-ivanov
Copy link
Contributor Author

sergei-ivanov commented Feb 1, 2022

Forgot to update CI environment in #11 to line up with Dockerfile

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #13 (c0bc94e) into master (f74f1dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files           2        2           
  Lines          99       99           
=======================================
  Hits           75       75           
  Misses         12       12           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74f1dc...c0bc94e. Read the comment docs.

Copy link
Owner

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

.goreleaser.yml Show resolved Hide resolved
Hashicorp does not produce terraform or provider builds for those targets.

Signed-off-by: Sergei Ivanov <[email protected]>
Copy link
Owner

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@invidian invidian merged commit 36ad777 into invidian:master Feb 3, 2022
@sergei-ivanov sergei-ivanov deleted the upgrade-go-1.17 branch February 3, 2022 12:49
@sergei-ivanov
Copy link
Contributor Author

Splendid. Let's try to create a new tag and release it. Also, can you please either send your public GPG key to the keyservers, or add it to this repo, or register with Keybase?

$ gpg --recv-keys 97187FA1271EC224
gpg: keyserver receive failed: No data

@invidian
Copy link
Owner

invidian commented Feb 3, 2022

I need to add changelog still, but sure.

My key is there:

$ gpg --keyserver keyserver.ubuntu.com --recv-keys 97187FA1271EC224
gpg: key 97187FA1271EC224: "Mateusz Gozdek <[email protected]>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1

I don't know what keyserver you use :)

You can also do curl -L https://github.com/invidian.gpg | gpg --import.

@sergei-ivanov
Copy link
Contributor Author

Ah yes, everything works with explicitly using ubuntu keyserver, thanks! And TIL about GitHub having a public URL for downloading committers' public keys -- amazing!

@invidian
Copy link
Owner

invidian commented Feb 3, 2022

Note, that I sign commits with 85C07FB75C70CF6A, but Terraform Registry does not support ed25519 keys yet, so I have to use my old key 97187FA1271EC224 for release artifacts signing.

@sergei-ivanov
Copy link
Contributor Author

I see the new release has already filtered through to terraform registry, and we are going to test it with my colleagues shortly. Thanks a lot for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants