-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI to Go 1.17 #13
Conversation
Signed-off-by: Sergei Ivanov <[email protected]>
Forgot to update CI environment in #11 to line up with Dockerfile |
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 2 2
Lines 99 99
=======================================
Hits 75 75
Misses 12 12
Partials 12 12 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
d39c1e4
to
9ba95cd
Compare
Hashicorp does not produce terraform or provider builds for those targets. Signed-off-by: Sergei Ivanov <[email protected]>
9ba95cd
to
c0bc94e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Splendid. Let's try to create a new tag and release it. Also, can you please either send your public GPG key to the keyservers, or add it to this repo, or register with Keybase?
|
I need to add changelog still, but sure. My key is there: $ gpg --keyserver keyserver.ubuntu.com --recv-keys 97187FA1271EC224
gpg: key 97187FA1271EC224: "Mateusz Gozdek <[email protected]>" not changed
gpg: Total number processed: 1
gpg: unchanged: 1 I don't know what keyserver you use :) You can also do |
Ah yes, everything works with explicitly using ubuntu keyserver, thanks! And TIL about GitHub having a public URL for downloading committers' public keys -- amazing! |
Note, that I sign commits with |
I see the new release has already filtered through to terraform registry, and we are going to test it with my colleagues shortly. Thanks a lot for the effort! |
Signed-off-by: Sergei Ivanov [email protected]