-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix console container startup issue #741
base: 1.6.x
Are you sure you want to change the base?
Conversation
console: | ||
healthcheck: | ||
enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be enabled for helm and CI as well? It's useful for seeing the deployment readiness, and CI should act the same as local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically helm way is enough being a common console.healthcheck.enabled
, as it'll get the same file CI was built from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note though that the helm way is hard coded to app state
Co-authored-by: andytson-inviqa <[email protected]>
Co-authored-by: andytson-inviqa <[email protected]>
I'm a bit nervous of the PR still, but now this sort of thing also needs to be a docker harness thing |
Resolves #666
Introduce Docker HealthCheck for local builds of the
console
The health check process:
docker-composer
will wait for the HealthCheck command to find theconsole
container in a healthy status before releasing control over the containers to the following commandsDefaults:
/HEALTHCHECK.txt
file/healthcheck.test.sh
scripthealthcheck.test.sh
is populated with steps that check if/HEALTHCHECK.txt
has been created