Set root to a temporary directory for unit tests #5833
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Several unit tests were accessing the real InvokeAI root, leading to non-deterministic behavior. This PR adds a module-level pytest fixture called
invokeai_root_dir
which returns a path pointing to an initialized (mostly empty) root directory. This is then applied to thetest_images
unit test.This PR also fixes an issue in the model manager’s
sync_to_dir
startup method, which was accessing the real root rather than the test root.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Before applying this PR, insert an
assert False
into the first test intests/app/routers/test_images.py
. In the logged failures, you will see messages about the model manager traversing the real root directory. After applying this PR, the messages will show the model manager traversing the temporary root directory.Merge Plan
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?