feat(ui): tweak image selection/hover styling #7302
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The styling in gallery for selected vs hovered was very similar, leading users to think that the hovered image was also selected. Reducing the borders for hovered images to a single pixel makes it easier to distinguish between selected and hovered.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The styling in gallery for selected vs hovered was very similar, leading users to think that the hovered image was also selected.
Reducing the borders for hovered images to a single pixel makes it easier to distinquich between selected and hovered.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149506274971631688/1304457546563584011
QA Instructions
Before:
Screen.Recording.2024-11-09.at.6.59.41.am.mov
After:
Screen.Recording.2024-11-09.at.6.58.52.am.mov
Checklist