-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feat: SDXL Color Compensation #8637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dunkeroni
wants to merge
7
commits into
invoke-ai:main
Choose a base branch
from
dunkeroni:sdxl_color_compensation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−5
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
490c77d
feat(nodes/UI): add SDXL color compensation option
dunkeroni 8a79b97
adjust value
dunkeroni 6c7136f
Merge branch 'main' into sdxl_color_compensation
lstein d991da7
Better warnings on wrong VAE base model
dunkeroni 04de466
Restrict XL compensation to XL models
dunkeroni be48c12
fix: BaseModelType missing import
dunkeroni 5a44414
(chore): appease the ruff
dunkeroni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
invokeai/frontend/web/src/features/parameters/components/VAEModel/ParamColorCompensation.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { FormControl, FormLabel, Switch } from '@invoke-ai/ui-library'; | ||
| import { useAppDispatch, useAppSelector } from 'app/store/storeHooks'; | ||
| import { InformationalPopover } from 'common/components/InformationalPopover/InformationalPopover'; | ||
| import { selectColorCompensation, setColorCompensation } from 'features/controlLayers/store/paramsSlice'; | ||
| import type { ChangeEvent } from 'react'; | ||
| import { memo, useCallback } from 'react'; | ||
| import { useTranslation } from 'react-i18next'; | ||
|
|
||
| const ParamColorCompensation = () => { | ||
| const { t } = useTranslation(); | ||
| const colorCompensation = useAppSelector(selectColorCompensation); | ||
|
|
||
| const dispatch = useAppDispatch(); | ||
|
|
||
| const handleChange = useCallback( | ||
| (e: ChangeEvent<HTMLInputElement>) => { | ||
| dispatch(setColorCompensation(e.target.checked)); | ||
| }, | ||
| [dispatch] | ||
| ); | ||
|
|
||
| return ( | ||
| <FormControl> | ||
| <InformationalPopover feature="colorCompensation"> | ||
| <FormLabel>{t('parameters.colorCompensation')}</FormLabel> | ||
| </InformationalPopover> | ||
| <Switch isChecked={colorCompensation} onChange={handleChange} /> | ||
| </FormControl> | ||
| ); | ||
| }; | ||
|
|
||
| export default memo(ParamColorCompensation); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it counterintuitive to offer menu items of "None" and "SDXL". Since only SDXL is supported, wouldn't it be better to use a boolean field here labeled "SDXL Color Compensation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partly to telegraph usage, but mostly for future proofing extra profiles/variants. Adding new options to the list will be less disruptive to existing workflow users than changing the input type.
As it is, the "SDXL" option right now tunes for fp16 SDXL 1.0 base VAE, and that mostly (but doesn't exactly) match the Illustrious VAEs. It's easier to leave the space open than to predict against future models with different VAE finetunes. Sounds like Pony V7.1 is going to try for a tuned VAE, but it's unclear if it will remain SDXL architecture or if it will ever be worth officially supporting AuraFlow models anyway.