-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Rework graph.py #8642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JPPhoto
wants to merge
10
commits into
invoke-ai:main
Choose a base branch
from
JPPhoto:rework-graph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework graph.py #8642
+367
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
approved these changes
Nov 8, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clean; tested with workflows involving multiple iterators and collections and produced expected output. I have a few minor code comments regarding handling of edge conditions.
Cleaned up code Co-authored-by: Lincoln Stein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
PRs that change frontend files
python
PRs that change python files
python-tests
PRs that change python tests
services
PRs that change app services
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This new
graph.pykeeps the same DAG model and validation but restructures runtime scheduling and readability: ready queues moved from publicdequefields to internal, non-serialized structures grouped by node class, with a configurable class priority and optional batch cap;indegreeis now seeded as unmet inputs (fixing iterator stalls) and children are enqueued via a single_enqueue_if_ready()helper;next()drains the active class queue, reseeds when empty, and_prepare()still expands iterators but with clearer predicates; minor fixes include catchingValueErrorindelete_edge, replacing magic port strings withITEM_FIELD/COLLECTION_FIELD, and renaming helper methods for clarity. Functionality and performance are preserved aside from the scheduling policy change and the indegree correctness fix.Additionally, there is a new
README.mdfile that explains a bit about the classes ingraph.pyso future developers can get a head start.Related Issues / Discussions
All of this was an effort to understand the execution engine better to support different types in the future - if, loops, and the like.
QA Instructions
I've run a number of workflows with these changes and all seems good.
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)