-
Notifications
You must be signed in to change notification settings - Fork 12
Laravel 11 & 12 compatibility #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
azakhozhiy
commented
Aug 20, 2025
- Added support for Laravel 11 and 12.
- No breaking changes introduced.
@azakhozhiy thanks for the PR. While the tests might pass locally, please make sure they also pass on supported OS/PHP/Laravel versions. See https://github.com/io238/laravel-iso-countries/actions/runs/17093995610 for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds compatibility support for Laravel 11 and 12 by updating the composer.json dependency constraints. The changes ensure the package can work with newer Laravel versions while maintaining backward compatibility.
- Updated illuminate package constraints to include Laravel 11 and 12
- Updated orchestra/testbench to support corresponding test environments
- Added explicit version number to composer.json
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@io238 I’ve updated Pest to ^2.0 for Laravel 11/12 support. Could you please re-run the tests to verify the workflow again? |
@azakhozhiy It still fails. Some of the combinations cannot be supported due to minimum requirements. We'll probably have to drop support for older Laravel versions otherwise the test matrix becomes quite messy. I suggest to only support Laravel 10, 11, 12 from now on. Older version can still use one of the previous versions. Here is a reference for the test matrix: https://github.com/spatie/package-skeleton-laravel/blob/main/.github/workflows/run-tests.yml - Let me add a commit with Codegen to adjust this. |
@io238 Ok, agreed |
@io238 I’ve broadened the dev constraint to I also set |
@io238 All checks are green ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks @azakhozhiy