Skip to content

Conversation

azakhozhiy
Copy link
Contributor

  • Added support for Laravel 11 and 12.
  • No breaking changes introduced.

@azakhozhiy
Copy link
Contributor Author

@io238
image

@io238
Copy link
Owner

io238 commented Aug 20, 2025

@azakhozhiy thanks for the PR. While the tests might pass locally, please make sure they also pass on supported OS/PHP/Laravel versions. See https://github.com/io238/laravel-iso-countries/actions/runs/17093995610 for details.

@io238 io238 requested review from Copilot and io238 August 20, 2025 09:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds compatibility support for Laravel 11 and 12 by updating the composer.json dependency constraints. The changes ensure the package can work with newer Laravel versions while maintaining backward compatibility.

  • Updated illuminate package constraints to include Laravel 11 and 12
  • Updated orchestra/testbench to support corresponding test environments
  • Added explicit version number to composer.json

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@io238 io238 mentioned this pull request Aug 20, 2025
@azakhozhiy
Copy link
Contributor Author

@io238 I’ve updated Pest to ^2.0 for Laravel 11/12 support. Could you please re-run the tests to verify the workflow again?

@io238
Copy link
Owner

io238 commented Aug 20, 2025

@azakhozhiy It still fails. Some of the combinations cannot be supported due to minimum requirements. We'll probably have to drop support for older Laravel versions otherwise the test matrix becomes quite messy.

I suggest to only support Laravel 10, 11, 12 from now on. Older version can still use one of the previous versions.

Here is a reference for the test matrix: https://github.com/spatie/package-skeleton-laravel/blob/main/.github/workflows/run-tests.yml - Let me add a commit with Codegen to adjust this.

@azakhozhiy
Copy link
Contributor Author

@io238 Ok, agreed
Dropping support for <10 and making this a 2.0 major release sounds good. I can update composer.json accordingly.

@azakhozhiy
Copy link
Contributor Author

@io238 I’ve broadened the dev constraint to pestphp/pest: ^1.0|^2.0|^3.0 so the CI matrix can resolve the proper Pest version per Laravel/Testbench combo (v1 for L8/9, v2 for L10, v3 for L11/12).

I also set minimum-stability to stable.
Could you please re-run the workflow?

@azakhozhiy
Copy link
Contributor Author

azakhozhiy commented Aug 20, 2025

@io238 All checks are green ✅
If everything looks good, please merge and tag v1.3.0 (adds Laravel 11 & 12 support). Thanks!

Copy link
Owner

@io238 io238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @azakhozhiy

Repository owner deleted a comment from codegen-sh bot Aug 20, 2025
Repository owner deleted a comment from codegen-sh bot Aug 20, 2025
Repository owner deleted a comment from codegen-sh bot Aug 20, 2025
Repository owner deleted a comment from codegen-sh bot Aug 20, 2025
@io238 io238 merged commit f657820 into io238:main Aug 20, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants