Update stateroles.md - clarify buttons #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify why buttons should have read attribute set to FALSE & suggestion to accomplish button events with ACK = TRUE
|
Ok... but the line under your change is wrong. Buttons must be read=false and write=true Ohh... I see you wrote the buttons sentence to sensors.... sensor != button |
this PR is on hold as we have to clarify the ACK flag first, will update my branch/PR as soon we have a decision here
uh ok, a line mix up in my IDE will fix that too |
Apollon77
requested changes
Nov 24, 2023
Working on it together with Tim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify why buttons should have read attribute set to FALSE & suggestion to accomplish button events with ACK = TRUE