Improve notifications for training day attendance and questions

[ronryv]

Improve notifications for training day attendance and questions

Summary

This PR enhances the admin interface to provide better visibility into unanswered questions and pending delay requests across training days within a training program.

Changes include:

• Added info messages on announcements/questions pages clarifying they only handle training program-level items, with guidance to visit training day pages
• Added notification badges (red circles) to the sidebar showing counts of unanswered questions and pending delay requests for each training day
• Added aggregate notification badges next to the "Training Days" section header
• Training program questions page now lists training days with unanswered questions with direct links
• Training program attendance page now lists training days with pending delay requests with direct links
• Added orange color styling (.unread-delay) to differentiate delay request indicators from question indicators
• Fixed CSS layout so notification badges stay inline with training day names (using flexbox)

Updates since last revision:

• Consolidated duplicate code into a single render_params_for_training_program() helper method in base.py that handles setting training_program, contest, unanswered questions count, and training day notifications
• Updated all training program handlers (trainingprogram.py, student.py, archive.py) to use the consolidated helper method, reducing code duplication significantly (~70 lines removed)
• Removed redundant notification badge next to "Attendance" menu item since the same information is now visible in the Training Days sidebar section
• Fixed overview and resourceslist pages to show training day notifications when accessed in a training program context (by detecting if the contest is a managing contest for a training program)

Review & Testing Checklist for Human

• Performance check: The render_params_for_training_program() in base.py queries unanswered questions and pending delay requests for each training day on every page load within a training program context. Verify this doesn't cause noticeable slowdown with many training days.
• Visual verification: Test the sidebar displays correctly - red badges for questions, orange badges for delay requests, badges stay inline with training day names (not wrapping to new line)
• Page coverage: Verify notification badges appear on ALL training program pages including overview and resourceslist (these were specifically reported as missing before)
• Link verification: Click through the links in the info messages on questions/attendance pages to ensure they navigate to the correct training day pages

Recommended test plan:

1. Create a training program with multiple training days
2. Add some unanswered questions and pending delay requests to different training days
3. Navigate to the training program and verify badges appear in sidebar on ALL pages (including overview and resourceslist)
4. Verify badges stay inline with training day names (no line wrapping)
5. Visit the questions page and verify the info message lists training days with unanswered questions
6. Visit the attendance page and verify the info message lists training days with pending delay requests
7. Verify badges disappear when all questions are answered / delay requests are resolved

Notes

• Link to Devin run: https://app.devin.ai/sessions/0eae93e7eebb44249877e60d5cdd0886
• Requested by: Ron Ryvchin (@ronryv)

Summary by CodeRabbit

• New Features

  • Per-training-day notification badges showing unanswered questions and pending delay requests, with totals at the Training Program level.
  • Lists of training days with unanswered questions and pending delays linking to the relevant pages (Questions, Delays/Extra Times).
  • Informational banners on Announcements and Attendance pages guiding users to relevant training-day views.

• Style

  • Improved sidebar flex layout and alignment for clearer badge display.
  • New amber/orange badge style for pending-delay notifications.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[coderabbitai]

📝 Walkthrough

Walkthrough

Centralizes training-program render context via BaseHandler.render_params_for_training_program(), aggregates per-training-day metrics (unanswered questions and pending delay requests), updates many admin handlers to use it, and surfaces these metrics in templates and sidebar styling.

Changes

Cohort / File(s)	Summary
Base helper cms/server/admin/handlers/base.py	Added render_params_for_training_program(training_program) that builds r_params with training_program, contest, per-training-day notifications (unanswered_questions, pending_delay_requests) and cumulative totals.
Archive & attendance handlers cms/server/admin/handlers/archive.py, cms/server/admin/handlers/trainingday.py	Switched handler r_params initialization to the new helper; added training_days_with_pending_delays usage in attendance/archive flows.
Training program handlers cms/server/admin/handlers/trainingprogram.py, cms/server/admin/handlers/contest.py	Replaced ad-hoc render param population with helper; moved per-day unanswered/pending-delay logic into helper; added DelayRequest import.
Student & misc handlers cms/server/admin/handlers/student.py	Replaced duplicated r_params setup with helper calls; preserved per-page overrides where needed (e.g., deletion flows).
Templates cms/server/admin/templates/base.html, cms/server/admin/templates/questions.html, cms/server/admin/templates/announcements.html, cms/server/admin/templates/training_program_attendance.html	Render new badges/notification blocks and conditional informational banners driven by training-program notification data (per-day unread and pending-delay badges, totals).
Styling cms/server/admin/static/aws_style.css	Added flex-based sidebar layout, badge styles, and .unread.unread-delay / .sidebar-badge.is-amber for pending-delay visuals.

Sequence Diagram(s)

(Skipped — changes are refactor/UI/data-aggregation focused and do not introduce a new multi-component sequential flow that requires diagramming.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Fix training program sidebar issues and add contest configuration #93: Modifies training-program/sidebar rendering and handlers — likely overlaps in r_params/template changes.
• Add delay request button for training days with configurable allow_delay_requests #83: Adds DelayRequest-related behavior and allow-delay logic that produces the pending-delay data aggregated here.
• Add archive training day feature with combined ranking #91: Touches attendance and combined-ranking handlers that this PR also updates to use per-day notification data.

Suggested reviewers

• Daniel-Aga

Poem

🐰 I hopped through params, neat and spry,
Collected delays beneath the sky,
Badges glow amber, red, and bright,
Templates sing with clearer light,
One helper now keeps context tight. 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main objectives of the PR: improving notifications for training day attendance and questions across multiple handlers and templates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ronryv]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[ronryv]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.