Skip to content

Use quotactl_fd syscall when available #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gollux merged 1 commit into from
Sep 1, 2025
Merged

Use quotactl_fd syscall when available #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 43 additions & 10 deletions rules.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include "isolate.h"

#include <errno.h>
#include <limits.h>
#include <mntent.h>
#include <stdio.h>
Expand All @@ -16,6 +17,7 @@
#include <sys/mount.h>
#include <sys/quota.h>
#include <sys/stat.h>
#include <sys/syscall.h>
#include <sys/vfs.h>
#include <unistd.h>

Expand Down Expand Up @@ -502,12 +504,47 @@ find_device(char *path)
return best_dev;
}

static void
quotactl_error(void)
{
// This errno has an outstandingly unhelpful message of "no such process".
if (errno == ESRCH)
die("Cannot set disk quota: quotas have not been enabled for this filesystem");
die("Cannot set disk quota: %m");
}

void
set_quota(void)
{
if (!block_quota)
return;

struct dqblk dq = {
.dqb_bhardlimit = block_quota,
.dqb_bsoftlimit = block_quota,
.dqb_ihardlimit = inode_quota,
.dqb_isoftlimit = inode_quota,
.dqb_valid = QIF_LIMITS,
};
void *dq_ptr = (void*)&dq;
int quota_op = QCMD(Q_SETQUOTA, USRQUOTA);

#ifdef SYS_quotactl_fd

// silence warning about unused function
(void)find_device;

int cwd_fd = open(".", O_DIRECTORY | O_PATH);
if (cwd_fd < 0)
die("open: %m");

if (syscall(SYS_quotactl_fd, cwd_fd, quota_op, box_uid, dq_ptr) < 0)
quotactl_error();

close(cwd_fd);

#else

char cwd[PATH_MAX];
if (!getcwd(cwd, sizeof(cwd)))
die("getcwd: %m");
Expand All @@ -528,16 +565,12 @@ set_quota(void)
if (cwd_st.st_dev != dev_st.st_rdev)
die("Identified %s as a filesystem on %s, but it is obviously false", cwd, dev);

struct dqblk dq = {
.dqb_bhardlimit = block_quota,
.dqb_bsoftlimit = block_quota,
.dqb_ihardlimit = inode_quota,
.dqb_isoftlimit = inode_quota,
.dqb_valid = QIF_LIMITS,
};
if (quotactl(QCMD(Q_SETQUOTA, USRQUOTA), dev, box_uid, (caddr_t) &dq) < 0)
die("Cannot set disk quota: %m");
msg("Quota: Set block quota %d and inode quota %d\n", block_quota, inode_quota);
if (quotactl(quota_op, dev, box_uid, dq_ptr) < 0)
quotactl_error();

free(dev);

#endif

msg("Quota: Set block quota %d and inode quota %d\n", block_quota, inode_quota);
}