Integrate changes from the CEOI #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, modals.html refers to undefined template variables.
Waiting for the edit lock to expire is too wearisome.
AJAX requests from the beforeunload event handler do not work with current browsers – the page is killed before the request completes. The beforeunload handler now asks "are you sure?" if there are unsaved data. The unload handler uses the Beacon mechanism to release the token after the page is unloaded. (However, the unload event is declared obsolete and need not be supported by all browsers. Especially mobile browsers are known not to issue it. On the other hand, this seems to be the only mechanism usable for automatic token release.) Buttons which cause the editor to close (including a new "save and exit" button) release the token independently of the unload handler. The "show PDF" button opens the PDF in a new tab, so it does not release the token. We also added logging to the JS console.
• It is based on Debian Bookworm now.
• Python packages are installed to a virtual environment.
• chromium-chromedriver is no longer needed.
• tzdata is installed when building the container instead of
in the entry point script.
• pip is not upgraded, Bookworm's version is recent enough.
• pip uses version constraints.
• Application is installed to a more logical /opt/translate/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings all non-controversial changes I made for CEOI 2024.
In particular, it updates the translation service to a recent version of Django and hopefully solves long-standing problems with edit locks.