Skip to content

Fix for Issue #22 - cannot call methods on autocomplete prior to initialization #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for Issue #22 - cannot call methods on autocomplete prior to initialization #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cfb16b
Moved Initialization on autocomplete. Fixes issue #22
Jan 23, 2013
45b1d72
Updated Minified Version with fixes for issue #22
Feb 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 75 additions & 75 deletions js/jquery.taghandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,81 @@ along with this program. If not, see < http://www.gnu.org/licenses/ >.
$("<div />").attr({ id: tagContainer.id + "_loader", title: "Saving Tags" }).addClass("tagLoader").appendTo(tagContainerObject.parent());
}

// adds autocomplete functionality for the tag names
if (opts.autocomplete && typeof($.fn.autocomplete) == 'function' && opts.initLoad) {
$(inputField).autocomplete({
source: tags.availableTags,
select: function (event, ui) {
var $el = $(this);
if (!checkTag($.trim(ui.item.value), tags.assignedTags)) {
if (opts.maxTags > 0 && tags.assignedTags.length >= opts.maxTags) {
alert('Maximum tags allowed: ' + opts.maxTags);
}
else {
var newTag = $.trim(ui.item.value);
var rc = 1;
if (typeof(opts.onAdd) == "function") {
rc = opts.onAdd.call(this, newTag);
}
if (rc || typeof(rc) == "undefined") {
tags = addTag(this, newTag, tags, opts.sortTags);
if (opts.updateURL !== '' && opts.autoUpdate) {
saveTags(tags, opts, tagContainer.id);
}
$(inputField).autocomplete("option", "source", tags.availableTags);
if (typeof(opts.afterAdd) == "function") {
opts.afterAdd.call(this, newTag);
}
}
}
$el.focus();
}
$el.val("");
return false;
},
minLength: opts.minChars
});
}
// Make an AJAX request to get the list of tags based on typed data
else if (opts.autocomplete && typeof($.fn.autocomplete) == 'function') {
$(inputField).autocomplete({
source: function (request, response) {
opts.getData[opts.queryname] = request.term;
var lastXhr = $.getJSON(opts.getURL, opts.getData, function (data, status, xhr) {
response(data.availableTags);
});
},
select: function (event, ui) {
var $el = $(this);
if (!checkTag($.trim(ui.item.value), tags.assignedTags)) {
if (opts.maxTags > 0 && tags.assignedTags.length >= opts.maxTags) {
alert('Maximum tags allowed: ' + opts.maxTags);
}
else {
var newTag = $.trim(ui.item.value);
var rc = 1;
if (typeof(opts.onAdd) == "function") {
opts.onAdd.call(this, newTag);
}
if (rc || typeof(rc) == "undefined") {
tags = addTag(this, $.trim(ui.item.value), tags, opts.sortTags);
if (opts.updateURL !== '' && opts.autoUpdate) {
saveTags(tags, opts, tagContainer.id);
}
if (typeof(opts.afterAdd) == "function") {
opts.afterAdd.call(this, newTag);
}
}
}
$el.focus();
}
$el.val('');
return false;
},
minLength: opts.minChars
});
}

// initializes the tag lists
// tag lists will be pulled from a URL
if (opts.getURL !== '' && opts.initLoad) {
Expand Down Expand Up @@ -429,81 +504,6 @@ along with this program. If not, see < http://www.gnu.org/licenses/ >.
}
});

// adds autocomplete functionality for the tag names
if (opts.autocomplete && typeof($.fn.autocomplete) == 'function' && opts.initLoad) {
$(inputField).autocomplete({
source: tags.availableTags,
select: function (event, ui) {
var $el = $(this);
if (!checkTag($.trim(ui.item.value), tags.assignedTags)) {
if (opts.maxTags > 0 && tags.assignedTags.length >= opts.maxTags) {
alert('Maximum tags allowed: ' + opts.maxTags);
}
else {
var newTag = $.trim(ui.item.value);
var rc = 1;
if (typeof(opts.onAdd) == "function") {
rc = opts.onAdd.call(this, newTag);
}
if (rc || typeof(rc) == "undefined") {
tags = addTag(this, newTag, tags, opts.sortTags);
if (opts.updateURL !== '' && opts.autoUpdate) {
saveTags(tags, opts, tagContainer.id);
}
$(inputField).autocomplete("option", "source", tags.availableTags);
if (typeof(opts.afterAdd) == "function") {
opts.afterAdd.call(this, newTag);
}
}
}
$el.focus();
}
$el.val("");
return false;
},
minLength: opts.minChars
});
}
// Make an AJAX request to get the list of tags based on typed data
else if (opts.autocomplete && typeof($.fn.autocomplete) == 'function') {
$(inputField).autocomplete({
source: function (request, response) {
opts.getData[opts.queryname] = request.term;
var lastXhr = $.getJSON(opts.getURL, opts.getData, function (data, status, xhr) {
response(data.availableTags);
});
},
select: function (event, ui) {
var $el = $(this);
if (!checkTag($.trim(ui.item.value), tags.assignedTags)) {
if (opts.maxTags > 0 && tags.assignedTags.length >= opts.maxTags) {
alert('Maximum tags allowed: ' + opts.maxTags);
}
else {
var newTag = $.trim(ui.item.value);
var rc = 1;
if (typeof(opts.onAdd) == "function") {
opts.onAdd.call(this, newTag);
}
if (rc || typeof(rc) == "undefined") {
tags = addTag(this, $.trim(ui.item.value), tags, opts.sortTags);
if (opts.updateURL !== '' && opts.autoUpdate) {
saveTags(tags, opts, tagContainer.id);
}
if (typeof(opts.afterAdd) == "function") {
opts.afterAdd.call(this, newTag);
}
}
}
$el.focus();
}
$el.val('');
return false;
},
minLength: opts.minChars
});
}

// sets the input field to show the autocomplete list on focus
// when there is no value
$(inputField).focus(function () {
Expand Down
Loading