feat(toolbar): add ionic theme styles #29656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#29655) Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This PR is being merged to ROU-10837 (ion-toolbar) where after a series of PR's are merged, the final PR will be done to next branch. This was done as most of these styles only make sense when used together in the context of the ion-toolbar, but there were a lot of changes that made sense to split in multiple PR's. - Added new scss file for Ionic theme. - Split the files between common and native. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This PR is being merged to ROU-10837 (ion-toolbar) where after a series of PR's are merged, the final PR will be done to next branch. This was done as most of these styles only make sense when used together in the context of the ion-toolbar, but there were a lot of changes that made sense to split in multiple PR's. - Added new scss file for Ionic theme. - Split the files between common and native. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This PR is being merged to ROU-10837 (ion-toolbar) where after a series of PR's are merged, the final PR will be done to next branch. This was done as most of these styles only make sense when used together in the context of the ion-toolbar, but there were a lot of changes that made sense to split in multiple PR's. - Added new scss file for Ionic theme. - Split the files between common and native. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This PR is being merged to ROU-10837 (ion-toolbar) where after a series of PR's are merged, the final PR will be done to next branch. This was done as most of these styles only make sense when used together in the context of the ion-toolbar, but there were a lot of changes that made sense to split in multiple PR's. - Added new scss file for Ionic theme. - Split the files between common and native. - Added ionic test for basic use-case. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information [Title Sample Screen](https://ionic-framework-5r1p09myo-ionic1.vercel.app/src/components/title/test/theme-ionic)
BenOsodrac
added
type: feature request
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Jun 27, 2024
thetaPC
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Revert the item-sliding snapshots. I recommend using:
git checkout origin/next core/src/components/item-sliding/test/basic/item-sliding.e2e.ts-snapshots/item-sliding-safe-area-*.png core/src/components/item-sliding/test/icons/item-sliding.e2e.ts-snapshots/item-sliding-icons-only-md-rtl-Mobile-Firefox-linux.pngThere was a problem hiding this comment.
Done, thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Added ionic theme scss architecture for
For the toolbar, it was decided to follow an approach closer to ios regarding the slots offering and behaviour, as it matches more closely the UX/UI requirements.
Does this introduce a breaking change?
Other information
Toolbar Sample Screen