-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(textarea): add styles for textarea solid fill #30685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4497193
- highlight should only appear on md;
JoaoFerreira-FrontEnd 686fda2
lint.fix;
JoaoFerreira-FrontEnd 59f7da9
lint.fix
JoaoFerreira-FrontEnd 3d79e0f
chore(): add updated snapshots
Ionitron 6ca66e5
Update core/src/components/textarea/textarea.ionic.scss
JoaoFerreira-FrontEnd 77ca2ba
Update core/src/components/textarea/textarea.ionic.solid.scss
JoaoFerreira-FrontEnd 11b08dc
- improvements on scss;
JoaoFerreira-FrontEnd b46fa0f
lint.fix
JoaoFerreira-FrontEnd 5fe5b72
Merge branch 'next' into ROU-12225
JoaoFerreira-FrontEnd 68c1775
Merge branch 'ROU-12225' of https://github.com/ionic-team/ionic-frame…
JoaoFerreira-FrontEnd 14735e8
chore(): add updated snapshots
Ionitron 91ca753
- fix has-focus state for ion-valid and ion-invalid;
JoaoFerreira-FrontEnd 48b359a
lint.fix;
JoaoFerreira-FrontEnd fb563a7
Merge branch 'next' into ROU-12225
JoaoFerreira-FrontEnd 9b5e218
- add visual test for textarea-readonly.ion-invalid
JoaoFerreira-FrontEnd e261fcd
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Binary file modified
BIN
-307 Bytes
(93%)
...ts/textarea-fill-shaped-solid-custom-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+315 Bytes
(110%)
...s/textarea-fill-shaped-solid-custom-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+159 Bytes
(100%)
...ts/textarea-fill-shaped-solid-custom-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+44 Bytes
(100%)
...e2e.ts-snapshots/textarea-fill-solid-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+456 Bytes
(110%)
...2e.ts-snapshots/textarea-fill-solid-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+435 Bytes
(110%)
...e2e.ts-snapshots/textarea-fill-solid-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -151,6 +151,31 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ title, screensh | |
| await expect(container).toHaveScreenshot(screenshot(`textarea-readonly-no-fill`)); | ||
| }); | ||
| }); | ||
|
|
||
| test.describe(title('solid'), () => { | ||
| test('should render readonly invalid textarea correctly', async ({ page }) => { | ||
| await page.setContent( | ||
| ` | ||
| <div class="container"> | ||
| <ion-textarea | ||
| label="Email" | ||
| label-placement="stacked" | ||
| value="[email protected]" | ||
| helper-text="Enter an email" | ||
| counter="true" | ||
| maxlength="20" | ||
| class="ion-touched ion-invalid" | ||
| readonly="true" | ||
| ></ion-textarea> | ||
| </div> | ||
| `, | ||
| config | ||
| ); | ||
|
|
||
| const container = page.locator('.container'); | ||
| await expect(container).toHaveScreenshot(screenshot(`textarea-readonly-solid-invalid`)); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
Binary file modified
BIN
-345 Bytes
(92%)
...-snapshots/textarea-readonly-no-fill-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
...snapshots/textarea-readonly-no-fill-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
...-snapshots/textarea-readonly-no-fill-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.4 KB
...hots/textarea-readonly-solid-invalid-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.59 KB
...ots/textarea-readonly-solid-invalid-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.52 KB
...hots/textarea-readonly-solid-invalid-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| @use "../../themes/ionic/ionic.globals.scss" as globals; | ||
|
|
||
| // Ionic Textarea Fill: Solid | ||
| // ---------------------------------------------------------------- | ||
|
|
||
| :host(.textarea-fill-solid) { | ||
| --border-color: #{globals.$ion-bg-input-bold-default}; | ||
| --border-width: #{globals.$ion-border-size-050}; | ||
| --background: #{globals.$ion-bg-input-bold-default}; | ||
| } | ||
|
|
||
| :host(.textarea-fill-solid) .textarea-wrapper { | ||
| border-bottom: none; | ||
|
|
||
| background: none; | ||
| } | ||
|
|
||
| :host(.textarea-fill-solid) .textarea-wrapper-inner { | ||
| @include globals.border-radius(var(--border-radius)); | ||
| position: relative; | ||
|
|
||
| border: var(--border-width) var(--border-style) var(--border-color); | ||
|
|
||
| background: var(--background); | ||
| } | ||
|
|
||
| :host(.textarea-fill-solid) .textarea-bottom { | ||
| --border-width: #{globals.$ion-scale-0}; | ||
| } | ||
|
|
||
| // Focus | ||
| // ---------------------------------------------------------------- | ||
|
|
||
| :host(.textarea-fill-solid.has-focus) { | ||
| --border-color: #{globals.$ion-border-focus-default}; | ||
| } | ||
|
|
||
| :host(.textarea-fill-solid.has-focus.ion-valid), | ||
| :host(.textarea-fill-solid.ion-touched.ion-invalid) { | ||
| --border-width: #{globals.$ion-border-size-050}; | ||
| --border-color: var(--highlight-color); | ||
| } | ||
|
|
||
| // Ionic Textarea - Readonly | ||
| // ---------------------------------------------------------------- | ||
|
|
||
| :host(.textarea-fill-solid.textarea-readonly) { | ||
| --background: #{globals.$ion-bg-input-bold-read-only}; | ||
| --border-color: #{globals.$ion-bg-input-bold-read-only}; | ||
| } | ||
|
|
||
| :host(.textarea-fill-solid.textarea-readonly.ion-invalid) { | ||
ShaneK marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| --border-color: rgba(#{globals.$ion-semantics-danger-base-rgb}, 0.6); | ||
| } | ||
|
|
||
| // Textarea - Disabled | ||
| // ---------------------------------------------------------------- | ||
|
|
||
| :host(.textarea-fill-solid.textarea-disabled) { | ||
| --background: #{globals.$ion-bg-input-bold-disabled}; | ||
| --border-color: #{globals.$ion-bg-input-bold-disabled}; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.