Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18.0 spec update #65

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Aug 15, 2024

WHAT

Just showing the changes to the 3.18.0 spec. No real action here yet until it's really released.

WHY

HOW

copilot:walkthrough

member x.DocumentSelector = x.DocumentSelector

type RegistrationParams = { Registrations: Registration[] }
type UnregistrationParams = { Unregisterations: Unregistration[] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the metamodel here maybe? Unregisterations isn't a word, Unregistrations would be (ish).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// This should correctly be named `unregistrations`. However, changing this
// is a breaking change and needs to wait until we deliver a 4.x version
// of the specification.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#unregistrationParams

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's amazing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants