-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating new function plot_ts for TS diagram #125
Conversation
Ignore it until the PR is done. Then we can fix the pre-commits. It helps old developers like myself to handle projects when many contributors but it sure increases barrier for contributions.
I merged #126 and rebased this one. You will need to perform a
I believe that |
gliderpy/plotting.py
Outdated
df: pd.DataFrame, | ||
profile_number: int, | ||
) -> tuple[plt.Figure, plt.Axes]: | ||
"""Make a TS diagram from a chosen profile number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should do the TS for the whole track. TS diagrams have many uses and the very first one is tp assess data quality, find oddities, etc. I believe that this function will be used to for quick data inspection like that, not really a final figure for a paper or refined research.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf , to create a plot with all the profiles, I would need to interpolate them so that they are in the same pressure intervals, adding NaN where the profiles are shallower than others. Do my thoughts make sense, or is there a simpler way?
@ocefpaf 🙌 |
I rebased it and remove the extra baseline directory inside the module. We keep the tests outside of it b/c we don't want to ship these PNGs with the package. |
New function plot_ts
Updated plots
Updated tests
Updated imagebaseline