Bug Fixes

+Optimized a bad query, that took a lot of time to be executed
iopietro · Feb 19, 2019 · a934c56 · mix5003 · Feb 20, 2019 · iopietro
1 parent 8edd6a8
commit a934c56
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/GameEngine/Database.php b/GameEngine/Database.php
@@ -785,9 +785,13 @@ function updateResource($vid, $what, $number) {
 
 	// no need to cache this method
 	public function hasBeginnerProtection($vid) {
-        list($vid) = $this->escape_input($vid);
-
-        $q = "SELECT u.protect FROM ".TB_PREFIX."users u,".TB_PREFIX."vdata v,".TB_PREFIX."odata o WHERE (u.id = v.owner AND v.wref = ".(int) $vid.") OR (u.id = o.owner AND o.wref = ".(int) $vid.") LIMIT 1";
+        list($vid) = $this->escape_input((int) $vid);
+        $q = "SELECT u.protect 
+              FROM s1_users u 
+              JOIN s1_vdata v ON u.id = v.owner
+              JOIN s1_odata o ON u.id = o.owner
+              WHERE v.wref = ". $vid ." OR o.wref = ". $vid . " 
+              LIMIT 1";
 		$result = mysqli_query($this->dblink,$q);
 		$dbarray = mysqli_fetch_array($result);