Merge pull request #7429 from iotaledger/fix/nft-media

fix: nft aspect ratio & crash when navigating to nft details from activity
iotaledger · Sep 14, 2023 · 9b59809 · 9b59809
2 parents e4e62c1 + bf7aea8
commit 9b59809
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/shared/components/MediaDisplay.svelte b/packages/shared/components/MediaDisplay.svelte
@@ -32,7 +32,7 @@
 
 <div class="h-full w-full object-cover">
     {#if htmlTag === ParentMimeType.Image}
-        <img {src} {alt} loading="lazy" class="w-full h-full" />
+        <img {src} {alt} loading="lazy" class="w-full h-full object-cover" />
     {:else if htmlTag === ParentMimeType.Video}
         <video
             loop={loop ? true : undefined}
@@ -42,7 +42,7 @@
             on:mouseenter={startPlaying}
             on:mouseleave={stopPlaying}
             preload="metadata"
-            class="w-full h-full"
+            class="w-full h-full object-cover"
         >
             <source {src} type={expectedType} />
         </video>

diff --git a/packages/shared/components/NftActivityDetails.svelte b/packages/shared/components/NftActivityDetails.svelte
@@ -31,6 +31,9 @@
         closePopup()
         $selectedNftId = activity.nftId
         $dashboardRouter.goTo(DashboardRoute.Collectibles)
+        // ugly hack to make sure router routes correctly
+        await tick()
+        // ugly hack to avoid a crash when navigating very fast between gallery and details
         await tick()
         $collectiblesRouter.goTo(CollectiblesRoute.Details)
     }