feat: use `SenderSignedData::input_objects` instead of `TransactionData::input_objects` #9304

valeriyr · 2025-11-17T10:10:54Z

Description of change

Replace the function usage in several places, but there are some that still need to be checked:

Indexing.
Replays.

Links to any relevant issues

fixes #9278

vercel · 2025-11-17T10:10:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments

Project	Deployment	Preview	Updated (UTC)
apps-backend	Ignored	Preview	Nov 26, 2025 8:36am
apps-ui-kit	Ignored	Preview	Nov 26, 2025 8:36am
iota-evm-bridge	Ignored	Preview	Nov 26, 2025 8:36am
iota-multisig-toolkit	Ignored	Preview	Nov 26, 2025 8:36am
rebased-explorer	Ignored	Preview	Nov 26, 2025 8:36am
wallet-dashboard	Ignored	Preview	Nov 26, 2025 8:36am

…th/9278-check-tx-inputs-usage

miker83z

Please also write a comment in the indexer and replay crates where it would be needed to include the MoveAuthenticator inputs. This will be done later.

miker83z · 2025-11-20T17:36:04Z

crates/iota-core/src/authority.rs

        }
    }

    fn read_objects_for_signing(


In this file, in the function fn index_tx there's:

cert.data() .intent_message() .value .input_objects()?

I haven't touched the places related to indexing in this PR because, in terms of the indexer, transaction inputs are always associated with TransactionData, so if this PR works, it is probably better to refactor in a dedicated PR.

valeriyr · 2025-11-21T08:52:45Z

Please also write a comment in the indexer and replay crates where it would be needed to include the MoveAuthenticator inputs. This will be done later.

It is easy to find the places where TransactionDataAPI::input_objects is used. The problem is that it is not always possible to just replace TransactionData::input_objects with SenderSignedData::input_objects because this data will not be interpreted correctly. So the best option will be to check this with the responsible team and create related issues, I think.

github-actions · 2025-11-24T15:44:27Z

✅ Vercel Preview Deployment is ready!

View Preview

…ere are several shared objects with the same id but different initial versions

miker83z

Just some nit renamings

miker83z · 2025-11-25T16:02:13Z

crates/iota-types/src/transaction.rs

+    /// example) can be duplicated in the transaction and authenticator
+    /// object lists, we load them independently to make it possible to
+    /// analyze the inputs in the transaction checkers.
+    pub fn collect_all_inputs_for_reading(&self) -> IotaResult<Vec<InputObjectKind>> {


Suggested change

pub fn collect_all_inputs_for_reading(&self) -> IotaResult<Vec<InputObjectKind>> {

pub fn collect_all_input_object_kind_for_reading(&self) -> IotaResult<Vec<InputObjectKind>> {

renamed in a51f8f4

miker83z · 2025-11-25T16:02:32Z

crates/iota-types/src/transaction.rs

    ///    the object to authenticate.
    /// 3. The object to authenticate from the sender `MoveAuthenticator`.
-    pub fn split_inputs_into_groups(
+    pub fn split_inputs_into_groups_for_reading(


Suggested change

pub fn split_inputs_into_groups_for_reading(

pub fn split_input_objects_into_groups(

Renamed in a51f8f4
But I left the _for_reading postfix at least for now. Since we have several input objects set, this postfix shows where the inputs should be used.

miker83z · 2025-11-25T16:03:54Z

crates/iota-types/src/transaction.rs

+    /// Merges another SharedInputObject into self.
+    /// If there is a conflict in mutability, the resulting object will be
+    /// mutable. Errors if the id or initial_shared_version do not match.
+    pub fn union(&mut self, other: &SharedInputObject) -> UserInputResult<()> {


Suggested change

pub fn union(&mut self, other: &SharedInputObject) -> UserInputResult<()> {

pub fn left_union(&mut self, other: &SharedInputObject) -> UserInputResult<()> {

As an option we can consider merge for the function name.

Renamed in a51f8f4

miker83z · 2025-11-25T16:04:21Z

crates/iota-types/src/transaction.rs

+    /// For shared objects, if either is mutable, the result is mutable.
+    /// Fails if either is not a shared object, or if the IDs or initial
+    /// versions do not match.
+    pub fn union(&mut self, other: &InputObjectKind) -> UserInputResult<()> {


Suggested change

pub fn union(&mut self, other: &InputObjectKind) -> UserInputResult<()> {

pub fn left_union_with_checks(&mut self, other: &InputObjectKind) -> UserInputResult<()> {

Renamed in a51f8f4

kodemartin

lgtm for the changes in iota-analytics-indexer

valeriyr requested review from Dkwcs and miker83z November 17, 2025 10:10

valeriyr self-assigned this Nov 17, 2025

iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Nov 17, 2025

valeriyr linked an issue Nov 17, 2025 that may be closed by this pull request

[AA] Check all codebase places where the input_objects (shared + owned objs) are used and consider usage of authenticator #9278

Closed

valeriyr force-pushed the vm-lang/aa-auth/9278-check-tx-inputs-usage branch 2 times, most recently from aa6978b to e188f74 Compare November 17, 2025 10:32

feat: use SenderSignedData input objects

6102764

valeriyr force-pushed the vm-lang/aa-auth/9278-check-tx-inputs-usage branch from e188f74 to 6102764 Compare November 17, 2025 11:16

Merge branch 'vm-lang/aa-auth/8116-feature-branch' into vm-lang/aa-au…

dd0a6e6

…th/9278-check-tx-inputs-usage

miker83z approved these changes Nov 20, 2025

View reviewed changes

refactor: rework SenderSignedData inputs access

c99dc43

valeriyr force-pushed the vm-lang/aa-auth/9278-check-tx-inputs-usage branch from 64d2145 to c99dc43 Compare November 24, 2025 11:47

valeriyr added 2 commits November 24, 2025 16:21

fix: SenderSignedData inputs-related functions

b55fa19

refactor: extract the shared objects union logic in dedicated functions

cfcd9f2

valeriyr added 2 commits November 24, 2025 18:31

refactor: return Vector of inputs instead of an iterator

d9c921c

refactor: SenderSignedData::shared_input_objects should panic if th…

5b50acb

…ere are several shared objects with the same id but different initial versions

valeriyr marked this pull request as ready for review November 25, 2025 15:51

valeriyr requested review from a team as code owners November 25, 2025 15:51

valeriyr removed request for a team November 25, 2025 15:51

valeriyr requested review from miker83z and removed request for a team November 25, 2025 15:51

miker83z approved these changes Nov 25, 2025

View reviewed changes

kodemartin approved these changes Nov 26, 2025

View reviewed changes

Dkwcs approved these changes Nov 26, 2025

View reviewed changes

fix: renaming according to the review comments

a51f8f4

valeriyr merged commit 330916d into vm-lang/aa-auth/8116-feature-branch Nov 26, 2025
25 of 30 checks passed

valeriyr deleted the vm-lang/aa-auth/9278-check-tx-inputs-usage branch November 26, 2025 08:38

	pub fn collect_all_inputs_for_reading(&self) -> IotaResult<Vec<InputObjectKind>> {
	pub fn collect_all_input_object_kind_for_reading(&self) -> IotaResult<Vec<InputObjectKind>> {

	pub fn split_inputs_into_groups_for_reading(
	pub fn split_input_objects_into_groups(

	pub fn union(&mut self, other: &SharedInputObject) -> UserInputResult<()> {
	pub fn left_union(&mut self, other: &SharedInputObject) -> UserInputResult<()> {

	pub fn union(&mut self, other: &InputObjectKind) -> UserInputResult<()> {
	pub fn left_union_with_checks(&mut self, other: &InputObjectKind) -> UserInputResult<()> {

feat: use SenderSignedData::input_objects instead of TransactionData::input_objects #9304

feat: use SenderSignedData::input_objects instead of TransactionData::input_objects #9304

Uh oh!

Conversation

valeriyr commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Links to any relevant issues

Uh oh!

vercel bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miker83z left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valeriyr commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

miker83z left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kodemartin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: use `SenderSignedData::input_objects` instead of `TransactionData::input_objects` #9304

feat: use `SenderSignedData::input_objects` instead of `TransactionData::input_objects` #9304

valeriyr commented Nov 17, 2025 •

edited

Loading

vercel bot commented Nov 17, 2025 •

edited

Loading