Skip to content

Conversation

@semenov-vladyslav
Copy link
Contributor

@semenov-vladyslav semenov-vladyslav commented Nov 18, 2025

Description of change

Previously, in case when a benchmark was run with severals workloads, only measurements for some last workloads were saved and used to plot stats.
This PR fixes that. Now, measurements for all workloads are saved. The plot.py script aggregates the stats from all relevant workloads.

Links to any relevant issues

Part of #8846.

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@semenov-vladyslav semenov-vladyslav requested a review from a team as a code owner November 18, 2025 14:31
@vercel
Copy link

vercel bot commented Nov 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-backend Ignored Ignored Preview Nov 24, 2025 1:25pm
apps-ui-kit Ignored Ignored Preview Nov 24, 2025 1:25pm
iota-evm-bridge Ignored Ignored Preview Nov 24, 2025 1:25pm
iota-multisig-toolkit Ignored Ignored Preview Nov 24, 2025 1:25pm
rebased-explorer Ignored Ignored Preview Nov 24, 2025 1:25pm
wallet-dashboard Ignored Ignored Preview Nov 24, 2025 1:25pm

@iota-ci iota-ci added core-protocol node Issues related to the Core Node team labels Nov 18, 2025
@semenov-vladyslav semenov-vladyslav marked this pull request as draft November 18, 2025 14:31
@semenov-vladyslav
Copy link
Contributor Author

I am not sure whether we should aggregate measurements for different workloads (as is currently implemented) or treat them as separate.

@jkrvivian jkrvivian force-pushed the core-node/feat/latency-for-payloads branch from 6d2d16f to 6369e41 Compare November 24, 2025 13:07
@jkrvivian jkrvivian marked this pull request as ready for review November 24, 2025 13:07
@jkrvivian jkrvivian force-pushed the core-node/feat/latency-for-payloads branch from 6369e41 to 9c4a00e Compare November 24, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-protocol node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants