feat(iota-core): Add report validation logic #9362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
oliviasaa
changed the title
oliviasaa
force-pushed
the
protocol-research/feat/score-integration-report-validation
branch
from
4be1744 to
cc4a0e2
Compare
bingyanglin
approved these changes
Nov 24, 2025
12 tasks
cyberphysic4l
approved these changes
Nov 24, 2025
| if !report.verify(self.committee.num_members()) { | ||
| // Since this verification happens after consensus, all authorities already | ||
| // agreed on the set of messages that would be verified by this method. Then, we | ||
| // can update scores according to the validation result directly, without the |
Contributor
There was a problem hiding this comment.
This comment is a bit long-winded but I think the message is a bit more simple: We have consensus on the inclusion of this misbehavior report in the DAG. Now we just objectively verify and either count it as valid or not.
piotrm50
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- config: gitGraph: {parallelCommits: true, mainBranchName: 'Feature', rotateCommitLabel: true} --- gitGraph commit id: "Initial commit" commit id: "Old Scorer" tag: "PR8530" commit id: "add ChangeEpochV4" tag: "PR9159" commit id: "add MisbehaviorReports" tag: "PR9175" commit id: "add ScoringMetrics" tag: "PR9176" commit id: "add Scorer" tag: "PR9177" commit id: "add ScoringMetricsStore" tag: "PR9178" checkout Feature branch report-validation commit id: "add report validation" branch scoring-function commit id: "add scoring function" branch report-creation commit id: "add report creation" checkout Feature merge report-validation tag: "THIS PR"Description of change
We build on top of the other PRs of this feature branch to enable the misbehavior reports validation logic.
How the change has been tested
Release Notes