feat(starfish): Limit synchronizer parallelism and add cache for verified blocks #9381
+404
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
piotrm50
changed the title
polinikita
reviewed
Nov 24, 2025
| && authorities.get(&peer).is_none() | ||
| { | ||
|
|
||
| // Check if this peer is already fetching this block |
Member
There was a problem hiding this comment.
Suggested change
| // Check if this peer is already fetching this block | |
| // Check if this peer is already fetching this header |
polinikita
reviewed
Nov 24, 2025
| continue; | ||
| } | ||
|
|
||
| // Count total authorities currently fetching this block |
Member
There was a problem hiding this comment.
Suggested change
| // Count total authorities currently fetching this block | |
| // Count total authorities currently fetching this header |
polinikita
approved these changes
Nov 24, 2025
Member
polinikita
left a comment
polinikita
left a comment
There was a problem hiding this comment.
For starfish, this seems to be less important improvement as the most heavy operation is the signature verification which takes 50-100microseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is a PR to test a potential fix for an issue with the header synchronizer. It limits parallelism of fetching blocks in the HeaderSynchronizer and implements an additional filter to avoid processing redundantly fetched blocks which should reduce CPU usage.
Links to any relevant issues
Resolves #9357
How the change has been tested