-
Notifications
You must be signed in to change notification settings - Fork 4
iip 6: exclude delegate nodes with lower than expected version #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CoderZhi
wants to merge
1
commit into
master
Choose a base branch
from
iip-6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| ``` | ||
| IIP: 6 | ||
| Title: Exclude delegate nodes with lower-than-expected chain version | ||
| Author: Zhi (@CoderZhi) | ||
| Status: Draft | ||
| Type: Standard Track | ||
| Category: Core | ||
| Created: 2019-10-31 | ||
| ``` | ||
|
|
||
| ## Simple Summary | ||
| Delegate nodes, with a lower-than-expected chain version, may cause empty consensus rounds (productivity issue) or even stuck the whole chain. This IIP will address this problem and improve the productivity and the stability of IoTeX blockchain. | ||
|
|
||
| ## Abstract | ||
| If a delegate node does not adopt a mandatory upgrade, the node will not be able to contribute in the future consensus. As a result, the corresponding proposal round of the delegate node will not produce any valid block. The current poll protocol expects voters to downvote this kind of delegate nodes to exclude them in follow up epochs. However, the productivity of IoTeX blockchain has been hurt if it happens. | ||
|
|
||
| It could be even worse if 1/3 or more delegates fail to adopt mandatory upgrades, that the whole chain will get stuck according to the consensus strategy we are using now. Nothing we can do, as what happened in https://github.com/iotexproject/iotex-bootstrap/blob/master/postmortem/2019-10-30.md, but waiting for these delegate nodes to upgrade themselves. | ||
|
|
||
| ## Motivation | ||
| The problem can be concurred by enforcing all delegate nodes to be up-to-date, however, the communication cost could be very high for a decentralized system like us. To prevent similar problems, we are proposing a new delegate election strategy to exclude delegate nodes who fail to adopt a mandatory upgrade. With this new strategy, these delegate nodes will be replaced by qualified backup delegate nodes until they adopt all mandatory upgrades. | ||
|
|
||
| ## Specification | ||
| A system level contract will be deployed onto IoTeX blockchain to register the chain versions of all delegate nodes. When starting a blockchain node, a version checking will be performed to update the version registered in the contract if necessary. In poll protocol, a delegate node will be filtered if its chain version registered in the contract is lower than expected, which means it has not adopted the latest version of mandatory upgrade. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. who sets the expected version in this contract? |
||
|
|
||
| ## Backwards Compatibility | ||
| This IIP will be a mandatory upgrade, so the backwards compatibility is not a concern. | ||
|
|
||
| ## Copyright | ||
| Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Exclude Nodes With Unexpected Binary Version from Consensus Delegates "