ETag for discovery resource requests with batch interface #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed. ℹ️ To verify your latest change (a1427cf), label this PR with |
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
10 times, most recently
from
841a162
to
ca433a5
Compare
Danielius1922
force-pushed
the
adam/feature/etag
branch
3 times, most recently
from
16a8bee
to
9649776
Compare
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
7 times, most recently
from
90507fe
to
7f7d5e2
Compare
jkralik
reviewed
Aug 14, 2023
jkralik
reviewed
Aug 14, 2023
jkralik
reviewed
Aug 14, 2023
jkralik
reviewed
Aug 14, 2023
jkralik
reviewed
Aug 14, 2023
jkralik
reviewed
Aug 14, 2023
jkralik
reviewed
Aug 15, 2023
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
from
d865ca4
to
813c683
Compare
jkralik
reviewed
Aug 15, 2023
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
from
fe03708
to
c8bf990
Compare
jkralik
reviewed
Aug 15, 2023
jkralik
reviewed
Aug 15, 2023
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
from
c8bf990
to
fe47ee7
Compare
jkralik
reviewed
Aug 16, 2023
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
5 times, most recently
from
7e887a0
to
e3b4bce
Compare
jkralik
approved these changes
Aug 18, 2023
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
from
e3b4bce
to
1e5745d
Compare
ocf-conformance-test-tool
bot
removed
the
OCF Conformance Testing
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
from
1e5745d
to
6d76808
Compare
When a GET request is made to the /oic/res resource with the batch interface, an array of contents representing discoverable and accessible resources is returned. This enhancement focuses on the calculation and handling of ETags in this scenario. ETags are utilized to track changes in resources. The ETag for each resource is updated whenever a change occurs. In the current IoT implementation the ETag value for resources continually increases, ensuring uniqueness among resources. In the context of the batch interface for the /oic/res resource the ETag value is calculated. The highest ETag value is selected from the resources included in the payload as well as the /oic/res resource itself as the ETag of the payload. This approach guarantees that the ETag used for the batch interface accurately represents the state of the included resources.
Danielius1922
force-pushed
the
adam/feature/etag-discovery-resource
branch
from
6d76808
to
9f333cb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues reported by SonarCloud and add tests.