Skip to content

Conversation

@jefft0
Copy link
Collaborator

@jefft0 jefft0 commented Oct 11, 2022

Update go.mod to use the latest berty/mobile which has this fix: golang/mobile#85 . In Swift this correctly uses the RequestBuilder.send() signature with Data? , so update Swift calls to unwrap it. Also in Swift, make RequestBuilder.sendToDict return a nullable [String: Any]? .

Update go.mod to use the latest berty/mobile which has this fix: golang/mobile#85 . In Swift this correctly uses the RequestBuilder.send() signature with Data? , so update Swift calls to unwrap it.
Signed-off-by: jefft0 <[email protected]>
Copy link
Member

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aeddi aeddi merged commit 95c93ae into ipfs-shipyard:master Oct 17, 2022
@jefft0 jefft0 deleted the fix/go.mod-update-berty-mobile-version branch October 17, 2022 16:15
@github-actions
Copy link

🎉 This PR is included in version 1.7.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants