chore: migrate bootstrap #474

gammazero · 2023-09-29T01:45:13Z

Migrating bootstrap service from kubo. The bootstrap package is used outside of kubo, and should be relocated into boxo so that kubo is not used as an IPFS library.

codecov · 2023-09-29T01:49:27Z

Codecov Report

Merging #474 (45426db) into main (46c47bc) will decrease coverage by 0.93%.
The diff coverage is 32.54%.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   65.96%   65.04%   -0.93%     
==========================================
  Files         206      204       -2     
  Lines       25392    25578     +186     
==========================================
- Hits        16751    16638     -113     
- Misses       7172     7454     +282     
- Partials     1469     1486      +17

Files	Coverage Δ
bootstrap/bootstrap.go	`32.54% <32.54%> (ø)`

... and 24 files with indirect coverage changes

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

Jorropo

I'm gonna refactor this to work without goprocess before reviewing.

bootstrap/bootstrap.go

hsanjuan · 2023-10-16T20:16:55Z

I'm gonna refactor this to work without goprocess before reviewing.

No please... merge and then do whatever... I would like to rely on this as part of upstream, otherwise I will copy-paste the whole thing directly.

Jorropo · 2023-10-16T20:49:18Z

@hsanjuan I'm not sure about the API exposed to consumers either, if I touch this code I can see this.
We want to have a high bar in what goes in boxo, we want to avoid merging code we don't want to maintain.

hsanjuan · 2023-10-18T11:02:18Z

@hsanjuan I'm not sure about the API exposed to consumers either, if I touch this code I can see this. We want to have a high bar in what goes in boxo, we want to avoid merging code we don't want to maintain.

If I run staticcheck --checks all ./... in boxo there are 328 warnings, with tons of undocumented stuff and things not following convention. So I don't think this code is any different from everything else that has been imported into Boxo (and didn't go through refactoring). Anything is better without goprocess in it, but this is nice-to-have as is right now, while it gets refactored.

Anyways, no big deal, I just have different approach but it's just matter of opinion.

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

BigLep · 2023-10-19T15:46:52Z

2023-10-19 conversation: Jorropo will refactor this to remove goprocess and then merge next week (week of 2023-10-23).

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

Jorropo · 2023-10-20T18:18:49Z

@gammazero just flagging that I plan to push on this branch, if you ever force push be sure to use --force-with-lease and not --force, this will error in case I pushed anything in the meanwhile, thx in advance.

License: MIT Signed-off-by: Łukasz Magiera <[email protected]> This commit was moved from ipfs/kubo@d35dac7

License: MIT Signed-off-by: Łukasz Magiera <[email protected]> This commit was moved from ipfs/kubo@0e6f8d4

closes #6391 License: MIT Signed-off-by: Raúl Kripalani <[email protected]> This commit was moved from ipfs/kubo@e8c2852

This commit was moved from ipfs/kubo@5d468e2

This commit was moved from ipfs/kubo@a53d480

We've deprecated this system and have yet to move to a new system. We might as well remove everything, switch to a new system, then deliberately trace the entire system. This commit was moved from ipfs/kubo@906f45e

Fixes: #9225 This commit was moved from ipfs/kubo@196887c

* feat(bootstrap): save connected peers as backup temporary bootstrap ones * fix: do not add duplicated oldSavedPeers, not using tags, reuse randomizeList * test: add regression test * chore: add changelog --------- Co-authored-by: Henrique Dias <[email protected]> Co-authored-by: Marcin Rataj <[email protected]> This commit was moved from ipfs/kubo@63561f3

This commit was moved from ipfs/kubo@f12b372

…0029) Fix panic when backup bootstrap peer load and save funcs are nil A panic occurs when the first bootstrap round runs is these functions are not assigned in the configuration: - `LoadBackupBootstrapPeers` - `SaveBackupBootstrapPeers` This fix assumes that it is acceptable for these functions to be nil, as it may be desirable to disable the backup peer load and save functionality. This commit was moved from ipfs/kubo@c46cbec

This commit was moved from ipfs/kubo@66590e3

Co-authored-by: Jorropo <[email protected]>

hacdias

This is fine by me. As per the standup, this is going to be merged as-is for tomorrow RC.

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

gammazero requested a review from a team as a code owner September 29, 2023 01:45

gammazero added a commit to ipfs/kubo that referenced this pull request Sep 29, 2023

chore: migrate bootstrap to ipfs/boxo

2cc8f64

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

gammazero mentioned this pull request Sep 29, 2023

chore: migrate bootstrap to ipfs/boxo ipfs/kubo#10158

Merged

gammazero force-pushed the chore/migrate-bootstrap branch from 6f465da to 56e6f4c Compare October 2, 2023 19:27

gammazero added a commit to ipfs/kubo that referenced this pull request Oct 2, 2023

chore: migrate bootstrap to ipfs/boxo

d513934

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

gammazero added a commit to ipfs/kubo that referenced this pull request Oct 5, 2023

chore: migrate bootstrap to ipfs/boxo

c476386

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

hacdias requested a review from Jorropo October 6, 2023 10:54

gammazero force-pushed the chore/migrate-bootstrap branch from 32dfb08 to f856dd0 Compare October 13, 2023 00:43

gammazero added a commit to ipfs/kubo that referenced this pull request Oct 13, 2023

chore: migrate bootstrap to ipfs/boxo

17119a2

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

gammazero force-pushed the chore/migrate-bootstrap branch from f856dd0 to 0661822 Compare October 13, 2023 17:16

Jorropo reviewed Oct 16, 2023

View reviewed changes

bootstrap/bootstrap.go Outdated Show resolved Hide resolved

hsanjuan mentioned this pull request Oct 16, 2023

Bootstrapping and peering ipfs/rainbow#27

Closed

gammazero added a commit to ipfs/kubo that referenced this pull request Oct 18, 2023

chore: migrate bootstrap to ipfs/boxo

110f98d

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

gammazero added a commit to ipfs/kubo that referenced this pull request Oct 20, 2023

chore: migrate bootstrap to ipfs/boxo

cbe7436

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

gammazero force-pushed the chore/migrate-bootstrap branch from 6b96e76 to b9896bd Compare October 25, 2023 21:55

magik6k and others added 9 commits October 31, 2023 17:41

Cleanup core package

fc8ea49

License: MIT Signed-off-by: Łukasz Magiera <[email protected]> This commit was moved from ipfs/kubo@d35dac7

bootstrap: cleanup randomSubsetOfPeers

d1e9268

License: MIT Signed-off-by: Łukasz Magiera <[email protected]> This commit was moved from ipfs/kubo@0e6f8d4

migrate to go-libp2p-core.

3f93896

closes #6391 License: MIT Signed-off-by: Raúl Kripalani <[email protected]> This commit was moved from ipfs/kubo@e8c2852

chore: deprecate go-ipfs-addr

c73b0a6

This commit was moved from ipfs/kubo@5d468e2

fix: migrate from deprecated warning function

c794bdb

This commit was moved from ipfs/kubo@a53d480

fix(tracing): remove event tracing

1b4de81

We've deprecated this system and have yet to move to a new system. We might as well remove everything, switch to a new system, then deliberately trace the entire system. This commit was moved from ipfs/kubo@906f45e

chore: bump go-libp2p v0.22.0 & go1.18&go1.19

735d89c

Fixes: #9225 This commit was moved from ipfs/kubo@196887c

style: gofumpt and godot [skip changelog] (#10081)

4ca63d9

This commit was moved from ipfs/kubo@f12b372

gammazero and others added 6 commits October 31, 2023 17:41

perf: make bootstrap saves O(N)

24ee956

This commit was moved from ipfs/kubo@66590e3

Move bootstrap from core to top level directory

a29dc5a

Update CHANGELOG and mod tidy

48b732d

Update CHANGELOG.md

133a465

Update bootstrap/bootstrap.go

45426db

Co-authored-by: Jorropo <[email protected]>

hacdias force-pushed the chore/migrate-bootstrap branch from 5ee3a08 to 45426db Compare October 31, 2023 16:41

hacdias changed the title ~~Chore/migrate bootstrap~~ chore: migrate bootstrap Oct 31, 2023

hacdias approved these changes Oct 31, 2023

View reviewed changes

hacdias enabled auto-merge October 31, 2023 16:55

hacdias merged commit 08b11e5 into main Oct 31, 2023
12 checks passed

hacdias deleted the chore/migrate-bootstrap branch October 31, 2023 17:12

hacdias pushed a commit to ipfs/kubo that referenced this pull request Oct 31, 2023

chore: migrate bootstrap to ipfs/boxo

4322b36

The bootstrap package is being used outside kubo, so should be relocated to boxo. See ipfs/boxo#474

BigLep mentioned this pull request Nov 9, 2023

Release 0.24 ipfs/kubo#10043

Closed

11 tasks

gammazero mentioned this pull request Jan 21, 2025

Opinionated libp2p connections management #419

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate bootstrap #474

chore: migrate bootstrap #474

gammazero commented Sep 29, 2023

codecov bot commented Sep 29, 2023 •

edited

Loading

Jorropo left a comment

hsanjuan commented Oct 16, 2023

Jorropo commented Oct 16, 2023

hsanjuan commented Oct 18, 2023

BigLep commented Oct 19, 2023

Jorropo commented Oct 20, 2023

hacdias left a comment

chore: migrate bootstrap #474

chore: migrate bootstrap #474

Conversation

gammazero commented Sep 29, 2023

codecov bot commented Sep 29, 2023 • edited Loading

Codecov Report

Jorropo left a comment

Choose a reason for hiding this comment

hsanjuan commented Oct 16, 2023

Jorropo commented Oct 16, 2023

hsanjuan commented Oct 18, 2023

BigLep commented Oct 19, 2023

Jorropo commented Oct 20, 2023

hacdias left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 29, 2023 •

edited

Loading