Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gw): duplicate blocks and range etags #486

Merged
merged 4 commits into from
Oct 31, 2023
Merged

fix(gw): duplicate blocks and range etags #486

merged 4 commits into from
Oct 31, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Oct 12, 2023 •
edited
Loading

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #486 (4cd1a11) into main (341c7da) will decrease coverage by 0.24%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   65.91%   65.67%   -0.24%     
==========================================
  Files         206      203       -3     
  Lines       25378    25321      -57     
==========================================
- Hits        16727    16629      -98     
- Misses       7183     7212      +29     
- Partials     1468     1480      +12
Files Coverage Δ
gateway/gateway.go 85.03% <100.00%> (-0.57%) ⬇️
gateway/handler_car.go 78.60% <85.18%> (+3.18%) ⬆️

... and 17 files with indirect coverage changes

@Jorropo Jorropo changed the title Ipip 0445 fix bugs in gateway Oct 13, 2023
@Jorropo Jorropo marked this pull request as ready for review October 13, 2023 03:43
@Jorropo Jorropo requested review from lidel and hacdias as code owners October 13, 2023 03:43
hacdias
hacdias requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe a test would be great.

gateway/gateway.go Show resolved Hide resolved
gateway/handler_car.go Outdated Show resolved Hide resolved
@BigLep BigLep mentioned this pull request Oct 24, 2023
Closed
11 tasks
@lidel lidel changed the title fix bugs in gateway fix(gw): duplicate blocks and range etags Oct 26, 2023
Jorropo and others added 4 commits October 31, 2023 11:20
@Jorropo @hacdias
gateway: fix: properly error on invalid dups
f899714 
The error handling code was unreachable since NewDuplicateBlocksPolicy always return implicit on unknown values.
@Jorropo @hacdias
gateway: fix: aliasing of hashes in car etag generation
40895aa
@Jorropo @hacdias
Update gateway/handler_car.go
5ac5e33 
Co-authored-by: Henrique Dias <[email protected]>
@hacdias
test: invalid car content type params
4cd1a11
@hacdias hacdias assigned hacdias and unassigned Jorropo Oct 31, 2023
@hacdias hacdias merged commit b0a265b into main Oct 31, 2023
14 checks passed
@hacdias hacdias deleted the ipip-0445 branch October 31, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees

@hacdias hacdias

Labels
skip/changelog
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorropo @hacdias