Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: add support for car-* query parameters #604

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 17, 2024

Option (A) from #603 (comment). Specifications: ipfs/specs#472.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.74%. Comparing base (0bbdc80) to head (70904d7).

❗ Current head 70904d7 differs from pull request most recent head 65cd401. Consider uploading reports for the commit 65cd401 to get more accurate results

Impacted file tree graph

@@                     Coverage Diff                      @@
##           gateway-content-location     #604      +/-   ##
============================================================
- Coverage                     59.79%   59.74%   -0.05%     
============================================================
  Files                           238      238              
  Lines                         29847    29860      +13     
============================================================
- Hits                          17847    17841       -6     
- Misses                        10388    10400      +12     
- Partials                       1612     1619       +7     
Files Coverage Δ
gateway/handler.go 79.33% <100.00%> (+0.03%) ⬆️
gateway/handler_car.go 79.89% <100.00%> (+1.28%) ⬆️

... and 9 files with indirect coverage changes

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's merge into #604.

There is one case where I want to add test (?format being different than Accept), but will do that there.

@lidel lidel merged commit 0793d5c into gateway-content-location Apr 17, 2024
11 of 12 checks passed
@lidel lidel deleted the gateway-car-params branch April 17, 2024 22:38
hacdias added a commit that referenced this pull request Apr 18, 2024
hacdias added a commit that referenced this pull request Apr 18, 2024
hacdias added a commit that referenced this pull request Apr 18, 2024
wenyue pushed a commit to wenyue/boxo that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants