This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
fix Deprecated packages and swarm peers convert error #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
godcong
commented
Jul 18, 2019
godcong
commented
- changed Deprecated packages to new packages
- fix swarm peers Latency convert error
- fixswarm peers address parse error
Stebalien
reviewed
Jul 18, 2019
response.go
Outdated
| if e != nil { | ||
| return e | ||
| } | ||
| fmt.Println(string(b)) |
There was a problem hiding this comment.
Probably didn't mean to check this patch in.
There was a problem hiding this comment.
i reverted it.
i'm sorry to patched it.
that's only my debug source.
swarm.go
Outdated
| @@ -98,7 +98,8 @@ func (api *SwarmAPI) Peers(ctx context.Context) ([]iface.ConnectionInfo, error) | |||
|
|
|||
| out.addr, err = multiaddr.NewMultiaddr(conn.Addr) | |||
| if err != nil { | |||
| return nil, err | |||
| //ignore error for get some address like this:ip4/94.130.135.167/tcp/4002/ws/ipfs/QmUEMvxS2e7iDrereVYc5SWPauXPyNwxcy9BXZrC1QTcHE | |||
There was a problem hiding this comment.
We probably don't want to ignore this peer. Let's just not set the addr and document this. Relates to multiformats/multiaddr#70.
There was a problem hiding this comment.
yes, This is better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.