Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and Enhance File Move Functionality (Closes #943) #2341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement and Enhance File Move Functionality (Closes #943) #2341

wants to merge 4 commits into from

Conversation

george-hub331
Copy link

hey @lidel, I attempted the issue with this PR

Description

This PR implements a file moving functionality in the IPFS Web UI, addressing issue #943. It adds support for moving single/multiple files and directories through both drag-and-drop and the move action button, with proper path handling and directory creation.

Changes

  1. Core Move Functionality:

    • Added proper path normalization to ensure correct destination paths
    • Implemented automatic directory creation for move destinations
    • Added handling for moving multiple selected files

  2. Move Modal Improvements:

    • Added directory path suggestions
    • Implemented directory creation info tooltip
    • Added validation to prevent invalid moves
    • Added auto directory creation on directories that do not exist

  3. Drag and Drop Enhancements:

    • Added support for dragging files(single/multiple) to breadcrumbs without issues
    • Implemented multi-file drag and drop operations
    • Proper handling of destination paths when dropping files

  4. Path Handling:

    • Added proper handling of existing directories
    • Implemented path normalization to prevent duplicate slashes
    • Added checks to prevent moving files into themselves

  5. Selected Actions More tab addition:

    • Added "More" options menu for responsive layout
    • Implemented collapsible actions based on screen width
    • Enhanced accessibility for action buttons

Testing

  • Tested moving single and multiple files
  • Verified directory creation works correctly
  • Tested drag and drop functionality
  • Confirmed move operations maintain file integrity

Closes #943

@george-hub331
feat: Enhance file drag and drop with multi-file support and improved…
7dcf075 
… path handling

- Improved path resolution and file move operations
- Added global file storage for drag operations
- Enhanced canDrop and drop logic to prevent invalid moves
@george-hub331
feat: Add move action and localization for file operations
0451597 
- Added 'move' localization key across multiple language files
- Implemented move modal and related functionality in files management
- Enhanced SelectedActions component with responsive menu and more actions
- Improved file move operations with better path handling and multi-file support
@george-hub331 george-hub331 requested a review from a team as a code owner March 2, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files: UI for moving multiple files
1 participant
@george-hub331