chore: trigger gc if disk at minimum free space limit #10651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check to see if the remaining free space is too low, and if so that should trigger GC to run. - New config value: Datastore.DiskMinFreePercent - Default value: 95 If the percentage of free space on the datastore volume drops below this amount than run GC. The percentage must be from 0 to 100. A value of 0 (unset) results in the default being used. A value of < 0 or > 100 disables this check.
hsanjuan
reviewed
Jan 3, 2025
There was a problem hiding this comment.
IMHO we should probably not add this as it adds complexity for unclear gain:
- Behaviour is unclear when when the repopath is a symlink to a different filesystem (i think not taken into account?). Also side-issues like repopath being one folder and "blocks" being a symlink, or a different mount. etc.
- There is no good default. A 5% of free space in a 10TiB system is inherently different from 5% in a 32GiB one. This means the setting should be customized (like MaxStorage so why adding a new option).
- In the end, if the user cares, they can set MaxStorage and if not not. This is an equivalent of expressing the same +code +extra-dependency +os-specific handling. Not worth it.
|
Closing in favor of setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check to see if the remaining free space is too low, and if so that should trigger GC to run.
If the percentage of free space on the datastore volume drops below this amount than run GC. The percentage must be from 0 to 100. A value of 0 (unset) results in the default being used. A value of < 0 or > 100 disables this check.
Closes #10648