allow none

ipython · Oct 17, 2024 · f0a3aff · f0a3aff
1 parent f805287
commit f0a3aff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ipykernel/kernelbase.py b/ipykernel/kernelbase.py
@@ -102,7 +102,7 @@ class Kernel(SingletonConfigurable):
     control_tasks: t.Any = List()
 
     debug_shell_socket = Any()
-    control_thread: Thread
+    control_thread: t.Optional[Thread] = None
     shell_channel_thread: Thread
 
     iopub_socket = Any()

diff --git a/pyproject.toml b/pyproject.toml
@@ -272,6 +272,8 @@ ignore = [
   "G002",
   # `open()` should be replaced by `Path.open()`
   "PTH123",
+  # use `X | Y` for type annotations, this does not works for dynamic getting type hints on older python
+  "UP007",
 ]
 unfixable = [
   # Don't touch print statements