InProcessKernelClient: Do not use run_sync if already in a running loop #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After reading through the run_sync code it looks like it might be something with async qt integration (https://github.com/codelv/asyncqtpy) not working in a nested thread. The code was working fine with the old nest_asyncio implementation. |
|
Hi @frmdstryr, this might be fixed by #1137, I'll be releasing a bugfix early next week. |
|
Indeed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application that uses an integrated Qt and asyncio event loop that embeds an ipython console using enaml's ipython console.
When the
run_synccall finishes here it attempts to close the main loop causing the whole app to hang.This just adds a check so if it's already in a running loop it just uses that instead.