Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 12 or 24 words. #1179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gilmarwsr
Copy link

Support for 12 or 24 words.
Improvements on error handling.

Support for 12 or 24 words.
Improvements on error handling.
@tony-iqlusion
Copy link
Member

@gilmarwsr sorry this went by the wayside. For some reason the tests didn't run, mind giving it another push?

Comment on lines +18 to +28
/// BIP39 can't find the word in the selected wordlist.
Bip39InvalidWord,

/// BIP39-related errors.
Bip39InvalidPhraseSize,

///BIP39 entropy must have 16 or 32 bytes
Bip39InvalidEntropySize,

///BIP39 invalid checksum
Bip39InvalidChecksum,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making several Bip39-prefixed variants, I think it would be better to have Bip39(bip39::Error) and a subdivided error type concerned with just those failure modes, even if that's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants