audit: fixup log entry serialization #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serializing a error, the audit logs are serialized from the bottom up. This introduces a new type wrapping the `response::Code` to fix that behavior. Previous behavior was breaking hashes of the audit log in the event of an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing response codes, in the case of an error, the payload would be serialized differently than what the device gives us.
In the case of a soft error, the response code should be serialized from the bottom up, and not from the midpoint like it was.
This was breaking the hash computation.
This introduces a new type for the purpose of audit log which represent the correct behavior. That fixes two cases I've observed: the log in the case of a reboot and the error in case an object would not exist.