Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grids to render stats #9

Merged
merged 3 commits into from
May 28, 2021
Merged

Use grids to render stats #9

merged 3 commits into from
May 28, 2021

Conversation

spenserblack
Copy link
Contributor

@spenserblack spenserblack commented May 13, 2021

Resizes TUI elements relative to terminal size.

Addresses #8

This does make some changes to the ratio of the element sizes within the UI, so it won't be a 1:1 match to the previous UI. The most noticeable change is that the TUI now takes up all of the height in the terminal. Let me know if there should be a maximum height/width set instead of always being "fullscreen".

These calls are redundant when the grid will decide the sizing of the
widgets.
@spenserblack spenserblack marked this pull request as ready for review May 13, 2021 13:36
@irevenko
Copy link
Owner

sorry for late review and thanks for helping

@irevenko irevenko merged commit 33be3b6 into irevenko:main May 28, 2021
@irevenko
Copy link
Owner

it is a little bit broken on windows havent checked on linux so need to fix
image

@irevenko
Copy link
Owner

So forks and stars per lang are shorter than they need to be
Avatar is too wide

@irevenko
Copy link
Owner

old look
image

@irevenko
Copy link
Owner

i reverted the commit

@spenserblack
Copy link
Contributor Author

spenserblack commented May 28, 2021

i reverted the commit

I'm surprised GitHub still thinks it's merged 😆

Avatar is too wide

Should be fixed by making sure its ratio is a square. Should be helped by enforcing a certain width/height ratio for the whole TUI. I should have tested on a wider screen -- I only checked on a vertical screen 🤦

So forks and stars per lang are shorter than they need to be

I'm not really sure what you mean, since forks per lang is shorter in the old version than in your screenshot of the new version. Anyway, this should be fixable by

  • Enforcing a height/width ratio for the TUI
  • Adjusting grid rows/columns for more preferable ratios

EDIT:

So forks and stars per lang are shorter than they need to be

I'm not really sure what you mean

Oh, perhaps you were referring to width? I interpreted "shorter" as referring to height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants