Draft
Conversation
added 3 commits
February 19, 2020 21:29
- add gitignore - fix sleep_ms timing - write more/better comments
- adds a blink_dynamic_clocks example - rustfmt
dwbrite
commented
Feb 20, 2020
| External = 2, | ||
| } | ||
|
|
||
| pub enum CpuFreq { |
Contributor
Author
There was a problem hiding this comment.
I'm uncertain on how much I like the values of this enum, but it does well enough for now.
dwbrite
commented
Feb 20, 2020
| } | ||
| } | ||
|
|
||
| pub fn mode_to_fbe(&'static mut self) -> Fbe { |
Contributor
Author
There was a problem hiding this comment.
this function feels... ehh? Maybe just the name is bad.
dwbrite
commented
Feb 20, 2020
| pub fn sleep_us(microseconds: u32) { | ||
| (0..microseconds).for_each(|_| { | ||
| (0..microseconds).for_each(|_| unsafe { | ||
| let mut inner = crate::mcg::F_CPU / 5_000_000; |
Contributor
Author
There was a problem hiding this comment.
reasoning: accessing static mut is always unsafe, so the only safe thing in here is the loop. I figure this is clearer 🤷♂️
dwbrite
commented
Feb 20, 2020
Contributor
Author
dwbrite
left a comment
dwbrite
left a comment
There was a problem hiding this comment.
Definitely needs docs and the API's not perfect, but otherwise looks fairly good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly focuses on supporting the
PEEmode of the MCG.Previously we could enter
PEE, but not escape it, and our code had no knowledge of its existence.Now, we can allow the k20dx256's clock speeds to dynamically change with a helper function
mcg.set_clocks(mcg::CpuFreq, sim). Additionally, static variables are now supported due to the addition of.bssand.datasections in the linker.In the future, more helper functions should be added for switching between MCG modes.
TODO: documentation and finalizing the API