-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
key: use nip19 identifiers everywhere #383
base: master
Are you sure you want to change the base?
Conversation
Changes npub/notes to nprofile/nevent, with known relays in the data. Changes to `src/js/lib/nostr-tools/nip19.ts` are copy paste from nostr-tools library.
I'm a bit hesitant to add nevent / nprofile creation because they're so much longer than note / npub, and many of the hinted relays might not even exist in 1 year. Relay urls are dependent on the centralized DNS or IP addresses. Npub / note content addresses are decentralized, elegant and timeless. |
I strongly agree, npub+event id should be the canonical way to refer to an
event for many reasons.
Even if a relay exists, 80% of the relays are very slow and are much better
used as backups.
…On Mon, May 1, 2023, 13:36 Martti Malmi ***@***.***> wrote:
I'm a bit opposed to nevent / nprofile because they're much longer (ugly
iris.to/ urls) and many of the hinted relays might not even exist in 1
year. Relay urls are dependent on the centralized DNS or IP addresses.
Content addresses are decentralized, elegant and timeless.
—
Reply to this email directly, view it on GitHub
<#383 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN5SWAFIAUDDV7FOR6V552TXEAGDDANCNFSM6AAAAAAXRBYRNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
nprofiles still contain the public key so they're no less decentralized nor less relevant in the future, in that sense. It's true they're longer. The changes in this pr use the nprofile/nevent relays as extras, not the sole only ones. I believe the goal of nprofile/nevent is to reduce dependence on the few huge relays that currently run the show. I don't see any consensus between the clients on how they do this. I like I leave it to you to decide. |
Ah, cool, actually it's great that nevent can contain public key. It's
definately an improvement over note+note_id.
…On Mon, May 1, 2023 at 10:33 PM npub1zenn0 ***@***.***> wrote:
nprofiles still contain the public key so they're no less decentralized
nor less relevant in the future, in that sense. It's true they're longer.
The changes in this pr use the nprofile/nevent relays as extras, not the
sole only ones.
I believe the goal of nprofile/nevent is to reduce dependence on the few
huge relays that currently run the show.
I don't see any consensus between the clients on how they do this. I like
nevent, makes me think the note will always be found, nprofile seems a
little redundant but I prefer the phrase nprofile over npub because it
has the word profile 😅
I leave it to you to decide.
—
Reply to this email directly, view it on GitHub
<#383 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN5SWAAMIYKL2WH4QFQLTN3XEB6B7ANCNFSM6AAAAAAXRBYRNI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
oh but actually |
@mmalmi do you have a timeline on the new iris frontend? I'd like for iris to support nprofiles at least in the search bar. I could remove the other nprofile stuff from this pr if need be? But if the new frontend is almost there, then I'm not gonna bother. With #382 , it's an almost surefire way of finding whichever profile/event you paste in. Also the CI is failing on lint errors which are also on main. |
I hope I can merge the new UI before the end of next week. |
Changes links to point to
nprofile
/nevent
rather thannpub
/note
.Changes to
src/js/lib/nostr-tools/nip19.ts
are copy paste fromnostr-tools library.