Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key: use nip19 identifiers everywhere #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

npub1zenn0
Copy link
Contributor

Changes links to point to nprofile/nevent rather than npub/note.

Changes to src/js/lib/nostr-tools/nip19.ts are copy paste from
nostr-tools library.

Changes npub/notes to nprofile/nevent, with known relays in the data.

Changes to `src/js/lib/nostr-tools/nip19.ts` are copy paste from
nostr-tools library.
@mmalmi
Copy link
Member

mmalmi commented May 1, 2023

I'm a bit hesitant to add nevent / nprofile creation because they're so much longer than note / npub, and many of the hinted relays might not even exist in 1 year. Relay urls are dependent on the centralized DNS or IP addresses. Npub / note content addresses are decentralized, elegant and timeless.

@adamritter
Copy link
Contributor

adamritter commented May 1, 2023 via email

@npub1zenn0
Copy link
Contributor Author

nprofiles still contain the public key so they're no less decentralized nor less relevant in the future, in that sense. It's true they're longer.

The changes in this pr use the nprofile/nevent relays as extras, not the sole only ones.

I believe the goal of nprofile/nevent is to reduce dependence on the few huge relays that currently run the show.

I don't see any consensus between the clients on how they do this. I like nevent, makes me think the note will always be found, nprofile seems a little redundant but I prefer the phrase nprofile over npub because it has the word profile 😅

I leave it to you to decide.

@adamritter
Copy link
Contributor

adamritter commented May 2, 2023 via email

@npub1zenn0
Copy link
Contributor Author

nprofile contains public key + relays, nevent contains event id + relays

@npub1zenn0
Copy link
Contributor Author

oh but actually nevent can have author too yeah, I didn't even notice that til now.

@npub1zenn0
Copy link
Contributor Author

npub1zenn0 commented May 11, 2023

@mmalmi do you have a timeline on the new iris frontend? I'd like for iris to support nprofiles at least in the search bar. I could remove the other nprofile stuff from this pr if need be? But if the new frontend is almost there, then I'm not gonna bother.

With #382 , it's an almost surefire way of finding whichever profile/event you paste in.

Also the CI is failing on lint errors which are also on main.

@mmalmi
Copy link
Member

mmalmi commented May 11, 2023

@mmalmi do you have a timeline on the new iris frontend? I'd like for iris to support nprofiles at least in the search bar. I could remove the other nprofile stuff from this pr if need be? But if the new frontend is almost there, then I'm not gonna bother.

With #382 , it's an almost surefire way of finding whichever profile/event you paste in.

Also the CI is failing on lint errors which are also on main.

I hope I can merge the new UI before the end of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants