Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform/miyoo: scripted versioning of IPK info #134

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Apaczer
Copy link

@Apaczer Apaczer commented Jul 15, 2024

well not sure how to aproach that extra btn, so adding one non-existent on these platforms.

@irixxxx
Copy link
Owner

irixxxx commented Jul 16, 2024

I'm OK with the packeting change, but what's that MODE button stuff needed for? Do we really need a default binding for the MODE button?

@Apaczer
Copy link
Author

Apaczer commented Jul 16, 2024

Wanted to cover whole 3-btn control pad, especially if we have free physical input. There is no MODE btn in def_binds so I'm adding random SDLKey which will not infect other bindings, then swapping it in plat_miyoo - not sure about approach. Regardless a few games use MODE explicitly for special actions beside standard use, so might be worth adding - must test those.

@@ -137,8 +140,10 @@ void plat_target_setup_input(void)
if (strcmp(plat_device, "miyoo") == 0) {
/* swapped A/B and X/Y keys */
keyswap(SDLK_LALT, SDLK_LCTRL);
keyswap(SDLK_MENU, SDLK_ESCAPE);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working with current setup...so dumping that idea, also missed the point of nameswap() obviously.

@Apaczer Apaczer changed the title platform/miyoo: scripted versioning and made use of SELECT btn platform/miyoo: scripted versioning of IPK info Jul 16, 2024
@Apaczer
Copy link
Author

Apaczer commented Jul 16, 2024

so it's a 7'th btn on a 6-btn pad in that case...I shall blame official nintendo guys for making 3-btn pad with MODE btn for switch (and my ignorance 😄). Ending here as there is no need for MODE btn for 3-btn input controller. Felt like it would be a shame to leave one key unbinded for miyoo.

@irixxxx
Copy link
Owner

irixxxx commented Jul 16, 2024

Heh... there are a lot of other devices having additional buttons, think only of L2/R2. I tried to chose a common configuration somehow similar on all supported devices. It's not cast in stone anyway since it's all reconfigurable, so those unbound keys aren't exactly lost.
Maybe one of the PEVB hotkey functions would be better to bind on that key.

@irixxxx irixxxx closed this Jul 16, 2024
@irixxxx irixxxx reopened this Jul 16, 2024
@irixxxx irixxxx merged commit 4a347fb into irixxxx:release-prepare Jul 16, 2024
22 checks passed
@Apaczer Apaczer deleted the miyoo-upd branch July 17, 2024 07:29
@Apaczer
Copy link
Author

Apaczer commented Jul 17, 2024

I believe we can leave it as is at least until v2.00 drops, adding other bind from PEVB may be too risky for regular user (aside from vol change).
Anyway I must ask, is there an easier approach for adding new bind for specific plat in inputmap.c without affecting other platforms?

@irixxxx
Copy link
Owner

irixxxx commented Jul 17, 2024

Only through the setup_input function. There's however no functionality yet to do so, only for remapping. It wouldn't be very difficult though. The exported array sizes should go away for a terminator in the arrays, then there could be some empty template entries at the end to add additional keys if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants