[stefanhipfel]

Summary

• BMCUserSet and BMCUserRotation CRD YAML files existed in config/crd/bases/ but were never registered in config/crd/kustomization.yaml, causing the operator to crash on startup with no matches for kind "BMCUserRotation" / "BMCUserSet" errors
• Added both CRDs to the kustomize manifest list
• Added corresponding Helm CRD templates to dist/chart/templates/crd/

Signed-off-by: Stefan Hipfel stefan.hipfel@sap.com

Summary by CodeRabbit

• New Features
  • BMC user sets and BMC user rotations are now included among the resources installed with the CRDs, making these resource types available alongside the existing CRDs.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: f6e5b745-a5bc-4e36-b016-2c61cb41f59c

Commits

Reviewing files that changed from the base of the PR and between d467087 and 56530fd.

Files ignored due to path filters: 3

• dist/chart/templates/crd/bmcuserrotations.baseboard.metal.ironcore.dev.yaml is excluded by !**/dist/**
• dist/chart/templates/crd/bmcusersets.baseboard.metal.ironcore.dev.yaml is excluded by !**/dist/**
• dist/install.yaml is excluded by !**/dist/**

Files selected for processing: 1

• config/crd/kustomization.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The CRD kustomization now includes the BMC user set and BMC user rotation base manifests as resources.

Changes: CRD registration

Layer / File(s)	Summary
Register BMC CRD manifests config/crd/kustomization.yaml	The resource list adds the BMC user set and BMC user rotation base manifests.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

• ironcore-dev/metal-maintenance-operator#140: Adds the BMC user API types and the CRD base manifests registered by this change.

Suggested labels: bug

Suggested reviewers: xkonni

Merge Risk: Minimal · up to 56530

The CRD registration change is mergeable with no identified blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the main change: adding the missing BMCUserSet and BMCUserRotation CRDs to Kustomize and Helm.
Description check		The description clearly explains the startup issue and the changes to Kustomize and Helm. It uses a Summary heading instead of the template's Proposed Changes heading and omits the Fixes field, but it…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the startup issue and the changes to Kustomize and Helm. It uses a Summary heading instead of the template's Proposed Changes heading and omits the Fixes field, but it provides the required change context and is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Checkov (3.3.29)

config/crd/kustomization.yaml

Process SyncManager-7:1:
Traceback (most recent call last):
File "/usr/lib64/python3.11/multiprocessing/process.py", line 314, in _bootstrap
self.run()
File "/usr/lib64/python3.11/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/usr/lib64/python3.11/multiprocessing/managers.py", line 592, in _run_server
server = cls._Server(registry, address, authkey, serializer)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/multiprocessing/managers.py", line 156, in init
self.listener = Listener(address=address, backlog=128)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/multiprocessing/connection.py", line 468, in init
self._listener = SocketListener(address, family, backlog)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/multiprocessing/connection.py", line 605, in init
self._soc

... [truncated 2054 characters] ...

xception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/checkov/main.py", line 655, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/site-packages/checkov/common/parallelizer/parallel_runner.py", line 133, in _run_function_multiprocess_fork
yield from self._drain_interleaved(processes)
File "/usr/local/lib/python3.11/site-packages/checkov/common/parallelizer/parallel_runner.py", line 185, in _drain_interleaved
raise value.internal_exception.with_traceback(value.internal_exception.traceback)
EOFError

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}