[stefanhipfel]

Reverts #298

Summary by CodeRabbit

• Chores
  • Configuration reload failures are now reported as errors directly. Kubernetes warning events and the reload-failure metric are no longer emitted.
  • Configuration loading continues to use the same source, parsing behavior, and successful configuration updates.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9252ddae-13c9-4373-ad6e-19a2f8f53890

Commits

Reviewing files that changed from the base of the PR and between 6f154a0 and 8ce22c4.

Files selected for processing: 3

• cmd/main.go
• internal/configloader/loader.go
• internal/telemetry/runtime/runtime.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The config loader no longer records reload failures with Prometheus metrics or Kubernetes Warning events. It returns lookup, missing-key, and parse errors directly. The FirmwareUpdate and telemetry runtime loader configurations no longer supply an event recorder.

Changes: Config loader reporting removal

Layer / File(s)	Summary
Return reload errors directly internal/configloader/loader.go	The loader no longer stores an event recorder or routes reload errors through recordFailure. It returns ConfigMap lookup, missing-key, and parse errors directly.
Remove recorder from loader setup cmd/main.go, internal/telemetry/runtime/runtime.go	Both loader configurations retain their existing cache, client, ConfigMap identifiers, parser, and logger settings, but no longer pass an event recorder.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

• ironcore-dev/metal-maintenance-operator#288: The supplied issue context connects this change’s removal of config-loader event integration to the reported AlertHandler panic when the critical event handler is disabled.

Possibly related PRs

• ironcore-dev/metal-maintenance-operator#298: This PR removes the loader recorder, reload-failure metric, and error-routing changes introduced by that PR.
• ironcore-dev/metal-maintenance-operator#291: This PR restores the loader behavior and setup established by that PR before the changes in PR #298.

Suggested reviewers: xkonni, nagadeesh-nagaraja

Merge Risk: Minimal · up to 8ce22

No actionable merge-blocking risk was identified in the reviewed changes.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description identifies the revert but does not follow the required template. It omits the Proposed Changes section, change details, and the Fixes section.	Use the required template. Add a Proposed Changes section with the reverted changes and complete the Fixes section, or state that no issue is fixed.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the primary change: reverting the config loader events and alert functionality.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 3 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn