Skip to content

add Match(Ext-)Communities to RoutingPolicy & NXOS support - #571

Merged
IvoGoman merged 1 commit into
mainfrom
feat/routemap-community
Oct 16, 2026
Merged

IvoGoman merged 1 commit into
mainfrom
feat/routemap-community

Conversation

@IvoGoman

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLI • Give Feedback 💬

@IvoGoman
IvoGoman added this pull request to stack #573 September 16, 2026 09:31
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 2 times, most recently from f81b44f to c771e6b Compare September 16, 2026 15:30
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Sep 17, 2026
@hardikdr hardikdr added this to Roadmap Sep 17, 2026
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 3 times, most recently from 295326f to 82262b9 Compare September 28, 2026 15:35
@swagner-de swagner-de added the review-scheduled The PR is being reviewed. label Oct 1, 2026
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch from 82262b9 to 6d1d6a9 Compare October 1, 2026 12:29
@IvoGoman
IvoGoman removed this pull request from stack #573 October 1, 2026 12:34
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch from 6d1d6a9 to 6ddc076 Compare October 1, 2026 12:34
@IvoGoman
IvoGoman changed the base branch from feat/ext-communityset-oc to feat/ext-communityset October 1, 2026 12:34
@IvoGoman
IvoGoman added this pull request to stack #609 October 1, 2026 12:34
Base automatically changed from feat/ext-communityset to main October 2, 2026 11:55
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 2 times, most recently from 7cd61c6 to e75317a Compare October 5, 2026 09:36
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 2 times, most recently from 8509b70 to 6287e3d Compare October 14, 2026 12:36
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 5 times, most recently from 3d72472 to 601eeea Compare October 15, 2026 12:13
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 5 times, most recently from 4f4445e to b2b5301 Compare October 16, 2026 07:40
Comment thread config/default/kustomization.yaml Resolved
Comment thread test/gnmi/gnmi_test.go Resolved
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch 3 times, most recently from e96c6ea to 2a7469f Compare October 16, 2026 13:23
felix-kaestner
felix-kaestner previously approved these changes Oct 16, 2026
Signed-off-by: Ivo Gosemann <ivo.gosemann@sap.com>
@IvoGoman
IvoGoman force-pushed the feat/routemap-community branch from 51dd0f4 to 42e3d2c Compare October 16, 2026 13:38
@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (4 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 2.42% (-0.01%) 👎
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 64.62% (+0.18%) 👍
github.com/ironcore-dev/network-operator/internal/controller/core 60.65% (+0.21%) 👍
github.com/ironcore-dev/network-operator/internal/controller/evpn 80.15% (-0.60%) 👎
github.com/ironcore-dev/network-operator/internal/controller/overlay 66.36% (-4.55%) 👎
github.com/ironcore-dev/network-operator/internal/controller/pool 72.15% (-1.48%) 👎
github.com/ironcore-dev/network-operator/internal/provider 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 16.82% (+0.23%) 👍
Coverage details

Compared to commit 88b04c8 (run #38907493477)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go 0.00% (ø) 2 0 2
github.com/ironcore-dev/network-operator/api/core/v1alpha1/routingpolicy_types.go 12.50% (ø) 8 1 7
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 2887 (+15) 0 2887 (+15)
github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller.go 69.55% (+3.05%) 266 (+72) 185 (+56) 81 (+16) 👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 4.37% (-0.00%) 2492 (+1) 109 2383 (+1) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap.go 59.38% (+18.47%) 32 (+10) 19 (+10) 13 🎉
github.com/ironcore-dev/network-operator/internal/provider/provider.go 0.00% (ø) 58 0 58

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap_test.go

@IvoGoman
IvoGoman merged commit 2780fd2 into main Oct 16, 2026
24 of 26 checks passed
@IvoGoman
IvoGoman deleted the feat/routemap-community branch October 16, 2026 13:56
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations. review-scheduled The PR is being reviewed. size/XXL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants