Skip to content

add support for set community additive - #590

Merged
IvoGoman merged 1 commit into
feat/routemap-communityfrom
feat/routepolicy-add
Oct 16, 2026
Merged

IvoGoman merged 1 commit into
feat/routemap-communityfrom
feat/routepolicy-add

Conversation

@IvoGoman

Copy link
Copy Markdown
Contributor

add option to enable setting community and extcommunity additive
instead of replacing the list.

@IvoGoman
IvoGoman added this pull request to stack #573 September 23, 2026 13:05
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch from d8de6a9 to 7a9bf32 Compare September 23, 2026 13:06
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Sep 24, 2026
@hardikdr hardikdr added this to Roadmap Sep 24, 2026
@IvoGoman
IvoGoman removed this pull request from stack #573 October 1, 2026 12:34
@IvoGoman
IvoGoman changed the base branch from feat/routepolicy-oc to feat/routemap-community October 1, 2026 12:35
@IvoGoman
IvoGoman added this pull request to stack #609 October 1, 2026 12:35
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch from 7a9bf32 to b916463 Compare October 1, 2026 12:36
@github-actions github-actions Bot added the size/L label Oct 1, 2026
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch 2 times, most recently from e1af5de to 5ef44c6 Compare October 5, 2026 09:36
@swagner-de swagner-de added the review-scheduled The PR is being reviewed. label Oct 8, 2026
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch from 5ef44c6 to 3eb2242 Compare October 14, 2026 15:57
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch 3 times, most recently from fd4a43b to d35a611 Compare October 15, 2026 07:48
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch 3 times, most recently from ef3f5e7 to fd98fee Compare October 15, 2026 13:03
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch from fd98fee to 6fc3266 Compare October 15, 2026 13:08
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch 3 times, most recently from 19b540f to 0fa66c6 Compare October 16, 2026 07:40
felix-kaestner
felix-kaestner previously approved these changes Oct 16, 2026
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch from 0fa66c6 to d265346 Compare October 16, 2026 12:13
@IvoGoman
IvoGoman force-pushed the feat/routepolicy-add branch 2 times, most recently from f893758 to 7af0ab4 Compare October 16, 2026 13:23
felix-kaestner
felix-kaestner previously approved these changes Oct 16, 2026
add option to enable setting community and extcommunity additive
instead of replacing the list.

Signed-off-by: Ivo Gosemann <ivo.gosemann@sap.com>
@github-actions

Copy link
Copy Markdown

Caution

No coverage for base commit 42e3d2c was found, so this report compares against its ancestor 88b04c8 (1 commit earlier)

Merging this branch changes the coverage (4 decrease, 3 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 2.42% (-0.01%) 👎
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 63.92% (-0.53%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 60.48% (+0.04%) 👍
github.com/ironcore-dev/network-operator/internal/controller/evpn 81.05% (+0.30%) 👍
github.com/ironcore-dev/network-operator/internal/controller/overlay 60.00% (-10.91%) 💀
github.com/ironcore-dev/network-operator/internal/controller/pool 72.57% (-1.05%) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 17.64% (+1.04%) 👍
Coverage details

Compared to commit 88b04c8 (run #38907493477)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/routingpolicy_types.go 12.50% (ø) 8 1 7
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 4.37% (-0.00%) 2492 (+1) 109 2383 (+1) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap.go 94.74% (+53.83%) 38 (+16) 36 (+27) 2 (-11) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap_test.go

@IvoGoman
IvoGoman merged commit 8957a90 into main Oct 16, 2026
26 checks passed
@IvoGoman
IvoGoman deleted the feat/routepolicy-add branch October 16, 2026 13:56
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations. review-scheduled The PR is being reviewed. size/L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants