Repository navigation
Implement Configured condition for Banner controller - #638
Merged
felix-kaestner merged 1 commit intoOct 15, 2026
Merged
Conversation
hardikdr
added
the
area/switch-automation
felix-kaestner
previously approved these changes
Oct 15, 2026
adamtrizuljak-sap
previously approved these changes
Oct 15, 2026
lparz1val
dismissed stale reviews from adamtrizuljak-sap and felix-kaestner
via
October 15, 2026 11:44
0f58f8d
lparz1val
force-pushed
the
feat/configured-condition-banner
branch
2 times, most recently
from
October 15, 2026 11:52
9bb671d to
f215b91
Compare
adamtrizuljak-sap
previously approved these changes
Oct 15, 2026
Extract Banner controller + test changes from branch feat/configured-condition. Set Configured condition only upon EnsureBanner result; don't set it upon K8s API or connectivity failures. Signed-off-by: Yurii Levchenko <yurii.levchenko@sap.com>
felix-kaestner
previously approved these changes
Oct 15, 2026
lparz1val
dismissed stale reviews from felix-kaestner and adamtrizuljak-sap
via
October 15, 2026 13:10
2059ecf
lparz1val
force-pushed
the
feat/configured-condition-banner
branch
from
October 15, 2026 13:10
38e3c22 to
2059ecf
Compare
felix-kaestner
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Banner controller + test changes from branch
feat/configured-condition#426. Find error paths in controller and handle them by settingconditions.FromError(err).Follow-up commit drops the
Configuredcondition on K8s API / provider-connect failures — those are transient infra blips, not device-config state, so they must not flap the condition.Tested against a Cisco NX-OS device: confirmed the
Configuredprint column renders, the condition set isReady/Configured/Pausedin order, the banner is written to the device, and re-reconciles report "configuration already up-to-date" (idempotent, no repeat Set).